[Bindings] Internalize generated dictionary keys using v8AtomicString.

[Bindings] Internalize generated dictionary keys using v8AtomicString.

These are small, fixed strings frequently used for property access.
It makes sense for them to be internalized.

BUG=685748
Review-Url: https://codereview.chromium.org/2658173003
Cr-Commit-Position: refs/heads/master@{#446763}
Committed: https://chromium.googlesource.com/chromium/src/+/de5f94759b81ede2952f75f8eb63ca917d2bb2aa

[jbroman, 2017-01-27 17:57:37]

The CQ bit was checked by jbroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 17:58:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbroman, 2017-01-27 18:00:18]

jbroman@chromium.org changed reviewers:
+ haraken@chromium.org

[jbroman, 2017-01-27 18:00:19]

jbroman@chromium.org changed reviewers:
+ haraken@chromium.org

[jbroman, 2017-01-27 18:00:19]

jochen@ pointed out that these aren't presently internalized:
https://bugs.chromium.org/p/chromium/issues/detail?id=685748#c11

It looks like it was probably an oversight; this seems a natural place to use
v8AtomicString.

[jbroman, 2017-01-27 18:00:19]

jochen@ pointed out that these aren't presently internalized:
https://bugs.chromium.org/p/chromium/issues/detail?id=685748#c11

It looks like it was probably an oversight; this seems a natural place to use
v8AtomicString.

[jochen (gone - plz use gerrit), 2017-01-27 18:19:25]

jochen@chromium.org changed reviewers:
+ jochen@chromium.org

[jochen (gone - plz use gerrit), 2017-01-27 18:19:25]

lgtm

[jochen (gone - plz use gerrit), 2017-01-27 18:19:49]

plz reference the bug in the CL description

[jbroman, 2017-01-27 18:21:53]

Sure. This isn't super targeted at that (it's just good generally), but it might
make a dent.

[jbroman, 2017-01-27 18:21:59]

Description was changed from

==========
[Bindings] Internalize generated dictionary keys using v8AtomicString.

These are small, fixed strings frequently used for property access.
It makes sense for them to be internalized.
==========

to

==========
[Bindings] Internalize generated dictionary keys using v8AtomicString.

These are small, fixed strings frequently used for property access.
It makes sense for them to be internalized.

BUG=685748
==========

[jbroman, 2017-01-27 18:22:05]

The CQ bit was unchecked by jbroman@chromium.org

[jbroman, 2017-01-27 18:22:06]

The CQ bit was checked by jbroman@chromium.org

[commit-bot: I haz the power, 2017-01-27 18:22:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2017-01-27 18:54:54]

LGTM

[commit-bot: I haz the power, 2017-01-27 20:56:11]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485541326525840, "parent_rev":
"9165a856ba6620f995d519d080a765426052d1b1", "commit_rev":
"de5f94759b81ede2952f75f8eb63ca917d2bb2aa"}

[commit-bot: I haz the power, 2017-01-27 20:56:46]

Description was changed from

==========
[Bindings] Internalize generated dictionary keys using v8AtomicString.

These are small, fixed strings frequently used for property access.
It makes sense for them to be internalized.

BUG=685748
==========

to

==========
[Bindings] Internalize generated dictionary keys using v8AtomicString.

These are small, fixed strings frequently used for property access.
It makes sense for them to be internalized.

BUG=685748

Review-Url: https://codereview.chromium.org/2658173003
Cr-Commit-Position: refs/heads/master@{#446763}
Committed:
https://chromium.googlesource.com/chromium/src/+/de5f94759b81ede2952f75f8eb63...
==========

[commit-bot: I haz the power, 2017-01-27 20:56:48]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/de5f94759b81ede2952f75f8eb63...