Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2658143003: [SAB] Handle non-numerics in Atomics.isLockFree (Closed)

Created:
3 years, 10 months ago by binji
Modified:
3 years, 10 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[SAB] Handle non-numerics in Atomics.isLockFree BUG=v8:4741 Review-Url: https://codereview.chromium.org/2658143003 Cr-Commit-Position: refs/heads/master@{#42822} Committed: https://chromium.googlesource.com/v8/v8/+/bfcc65d675da9dab65a3a74e119c518d3ff780df

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M src/js/harmony-atomics.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/atomics.js View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
binji
3 years, 10 months ago (2017-01-27 22:06:22 UTC) #2
Camillo Bruni
lgtm
3 years, 10 months ago (2017-01-30 19:17:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2658143003/1
3 years, 10 months ago (2017-01-31 19:07:25 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 19:33:55 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/bfcc65d675da9dab65a3a74e119c518d3ff...

Powered by Google App Engine
This is Rietveld 408576698