Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 2658133002: Convert BrowserPluginGuest to use the new navigation callbacks. (Closed)

Created:
3 years, 11 months ago by jam
Modified:
3 years, 11 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert BrowserPluginGuest to use the new navigation callbacks. BUG=682002 Review-Url: https://codereview.chromium.org/2658133002 Cr-Commit-Position: refs/heads/master@{#446511} Committed: https://chromium.googlesource.com/chromium/src/+/be38048f78a75a9b4ad3e10e4881c0bc3c11ecb5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M content/browser/browser_plugin/browser_plugin_guest.h View 1 chunk +1 line, -4 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.cc View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
jam
3 years, 11 months ago (2017-01-26 23:00:39 UTC) #5
Fady Samuel
lgtm
3 years, 11 months ago (2017-01-26 23:05:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2658133002/1
3 years, 11 months ago (2017-01-26 23:34:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2658133002/1
3 years, 11 months ago (2017-01-27 00:38:42 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-27 01:01:50 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/be38048f78a75a9b4ad3e10e4881...

Powered by Google App Engine
This is Rietveld 408576698