Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 2658113002: Merged: [runtime] Fix Array.prototype.concat with complex @@species (Closed)

Created:
3 years, 11 months ago by Camillo Bruni
Modified:
3 years, 11 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, ulan
Target Ref:
refs/pending/branch-heads/5.7
Project:
v8
Visibility:
Public.

Description

Merged: [runtime] Fix Array.prototype.concat with complex @@species Revision: e5608155aeb18a76fdb495d446efe1f9e33e749b BUG=682194 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=verwaest@chromium.org Review-Url: https://codereview.chromium.org/2658113002 Cr-Commit-Position: refs/branch-heads/5.7@{#27} Cr-Branched-From: 975e9a320b6eaf9f12280c35df98e013beb8f041-refs/heads/5.7.492@{#1} Cr-Branched-From: 8d76f0e3465a84bbf0bceab114900fbe75844e1f-refs/heads/master@{#42426} Committed: https://chromium.googlesource.com/v8/v8/+/fbcc5463a0e79ab95e150fbe4b804a8c6baa8ba2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -8 lines) Patch
M src/builtins/builtins-array.cc View 7 chunks +18 lines, -8 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-682194.js View 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Camillo Bruni
3 years, 11 months ago (2017-01-26 21:21:17 UTC) #1
Camillo Bruni
NOTE: This script will no longer automatically update include/v8-version.h and create a tag. This is ...
3 years, 11 months ago (2017-01-26 21:21:18 UTC) #2
Toon Verwaest
lgtm
3 years, 11 months ago (2017-01-26 21:47:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2658113002/1
3 years, 11 months ago (2017-01-26 21:51:07 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 21:51:22 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/fbcc5463a0e79ab95e150fbe4b804a8c6ba...

Powered by Google App Engine
This is Rietveld 408576698