Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2658093006: Implement Federated PSL Matches in Native Backends (Closed)

Created:
3 years, 10 months ago by vasilii
Modified:
3 years, 10 months ago
Reviewers:
vasilii
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Implement Federated PSL Matches in Native Backends In a follow-up to http://crrev.com/2634163002 this change implements the feature to fetch federated PSL matches in the native backends as well. BUG=666340 R=vasilii@chromium.org Review-Url: https://codereview.chromium.org/2652243002 Cr-Commit-Position: refs/heads/master@{#446634} (cherry picked from commit bb90def05df40c3aebf65c5a65c6376baf779f61) Review-Url: https://codereview.chromium.org/2658093006 . Cr-Commit-Position: refs/branch-heads/2987@{#144} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/aac9e7fe87fc45200239196772588dc99b041cdd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+364 lines, -73 lines) Patch
M chrome/browser/password_manager/native_backend_gnome_x.cc View 2 chunks +30 lines, -26 lines 0 comments Download
M chrome/browser/password_manager/native_backend_gnome_x_unittest.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M chrome/browser/password_manager/native_backend_libsecret.cc View 3 chunks +33 lines, -29 lines 0 comments Download
M chrome/browser/password_manager/native_backend_libsecret_unittest.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/login_database.cc View 1 chunk +18 lines, -18 lines 0 comments Download
M components/password_manager/core/browser/psl_matching_helper.h View 2 chunks +17 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/psl_matching_helper.cc View 2 chunks +48 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/psl_matching_helper_unittest.cc View 2 chunks +185 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
vasilii
3 years, 10 months ago (2017-01-27 15:27:57 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
aac9e7fe87fc45200239196772588dc99b041cdd.

Powered by Google App Engine
This is Rietveld 408576698