Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Issue 2658083002: Revert of Move logic from memory_mac to allocator_interception_mac. (Closed)

Created:
3 years, 11 months ago by ajuma
Modified:
3 years, 11 months ago
CC:
chromium-reviews, wfh+watch_chromium.org, mac-reviews_chromium.org, Dai Mikurube (NOT FULLTIME), vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move logic from memory_mac to allocator_interception_mac. (patchset #5 id:80001 of https://codereview.chromium.org/2649973003/ ) Reason for revert: This seems to be causing compile to fail on the Mac GPU FYI Asan bot, with error: ../../base/allocator/allocator_interception_mac.mm:320:3: error: use of undeclared identifier 'DeprotectMallocZone' DeprotectMallocZone(zone, &reprotection_start, &reprotection_length, ^ 1 error generated. See https://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%20GPU%20ASAN%20Release/builds/1407/steps/compile/logs/stdio and https://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%20GPU%20ASAN%20Release?numbuilds=100 Original issue's description: > Move logic from memory_mac to allocator_interception_mac. > > This CL is a refactor and has no intended behavior changes. > > This CL moves the allocator interception logic from base/process/memory_mac.mm > to base/allocator/allocator_interception_mac.mm in preparation for an > implementation of the allocator shim. > > BUG=665567 > > Review-Url: https://codereview.chromium.org/2649973003 > Cr-Commit-Position: refs/heads/master@{#446234} > Committed: https://chromium.googlesource.com/chromium/src/+/9550b71347ce9acbe2875fb75ea46ec096230506 TBR=primiano@chromium.org,mark@chromium.org,erikchen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=665567 Review-Url: https://codereview.chromium.org/2658083002 Cr-Commit-Position: refs/heads/master@{#446346} Committed: https://chromium.googlesource.com/chromium/src/+/e9942e23fec9e2bca8ebd70f79feb2120943b54b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+526 lines, -555 lines) Patch
M base/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D base/allocator/allocator_interception_mac.h View 1 chunk +0 lines, -23 lines 0 comments Download
D base/allocator/allocator_interception_mac.mm View 1 chunk +0 lines, -526 lines 0 comments Download
M base/process/memory_mac.mm View 2 chunks +526 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
ajuma
Created Revert of Move logic from memory_mac to allocator_interception_mac.
3 years, 11 months ago (2017-01-26 16:33:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2658083002/1
3 years, 11 months ago (2017-01-26 16:34:48 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/e9942e23fec9e2bca8ebd70f79feb2120943b54b
3 years, 11 months ago (2017-01-26 16:36:06 UTC) #6
erikchen
On 2017/01/26 16:36:06, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
3 years, 11 months ago (2017-01-26 19:00:41 UTC) #7
ajuma
On 2017/01/26 19:00:41, erikchen wrote: > On 2017/01/26 16:36:06, commit-bot: I haz the power wrote: ...
3 years, 11 months ago (2017-01-26 19:07:06 UTC) #8
Primiano Tucci (use gerrit)
3 years, 11 months ago (2017-01-26 19:10:32 UTC) #9
Message was sent while issue was closed.
On 2017/01/26 19:07:06, ajuma wrote:
> On 2017/01/26 19:00:41, erikchen wrote:
> > On 2017/01/26 16:36:06, commit-bot: I haz the power wrote:
> > > Committed patchset #1 (id:1) as
> > >
> >
>
https://chromium.googlesource.com/chromium/src/+/e9942e23fec9e2bca8ebd70f79fe...
> > 
> > Please note that this reverted the wrong CL. You actually wanted:
> > https://codereview.chromium.org/2650363002/
> 
> Yeah, sorry about that! (Also note that this had the effect of reverting both
> CLs.)

Yeah that sounds a genuine problem with the revert button. Erik filed
crbug.com/685715. No worries.

Powered by Google App Engine
This is Rietveld 408576698