Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Unified Diff: chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html

Issue 2658063004: Fix cups manufacturer and model dropdowns. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html
diff --git a/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html b/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html
index f08c5e7b3e3f81f5233fe074b8c7bc919eb50fa1..14c914290c01429696832dff42e1dba0fedd1f2c 100644
--- a/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html
+++ b/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html
@@ -58,9 +58,11 @@
<paper-input-container no-label-float>
<input is="iron-input" type="search" on-tap="onTap_"
on-search="onInputValueChanged_" on-change="onChange_" incremental>
- <paper-icon-button suffix id="searchIcon" icon="cr:search" hidden>
+ <paper-icon-button suffix id="searchIcon" icon="cr:search" on-tap="onTap_"
+ hidden>
</paper-icon-button>
- <paper-icon-button suffix id="dropdownIcon" icon="cr:arrow-drop-down">
+ <paper-icon-button suffix id="dropdownIcon" icon="cr:arrow-drop-down"
+ on-tap="onTap_">
dpapad 2017/01/27 22:24:25 Instead of adding the onTap_ listener three times,
Dan Beam 2017/01/27 22:50:32 +1, yeah, that seems cleaner
Carlson 2017/01/31 18:39:34 Good idea, done.
</paper-icon-button>
</paper-input-container>
<iron-dropdown horizontal-align="left" vertical-align="top"
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698