Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2658063003: Misc service_manager and service test cleanup (Closed)

Created:
3 years, 10 months ago by Ken Rockot(use gerrit already)
Modified:
3 years, 10 months ago
CC:
Aaron Boodman, abarth-chromium, alokp+watch_chromium.org, chfremer+watch_chromium.org, chromium-reviews, darin (slow to review), feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, posciak+watch_chromium.org, qsr+mojo_chromium.org, rjkroege, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Misc service_manager and service test cleanup BUG=672614 TBR=ben@chromium.org Review-Url: https://codereview.chromium.org/2658063003 Cr-Commit-Position: refs/heads/master@{#446598} Committed: https://chromium.googlesource.com/chromium/src/+/0f7b4ea0709c59fbd53c222603a19055b98cee65

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -187 lines) Patch
M media/mojo/services/BUILD.gn View 2 chunks +8 lines, -2 lines 0 comments Download
M services/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M services/navigation/BUILD.gn View 3 chunks +15 lines, -4 lines 0 comments Download
M services/service_manager/background/BUILD.gn View 2 chunks +0 lines, -17 lines 0 comments Download
D services/service_manager/background/background_service_manager_main.h View 1 chunk +0 lines, -12 lines 0 comments Download
D services/service_manager/background/background_service_manager_main.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M services/service_manager/public/cpp/test/BUILD.gn View 1 chunk +2 lines, -25 lines 0 comments Download
M services/service_manager/public/cpp/test/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M services/service_manager/public/cpp/test/run_all_service_tests.cc View 1 chunk +18 lines, -2 lines 0 comments Download
D services/service_manager/public/cpp/test/run_all_service_tests_with_catalog.cc View 1 chunk +0 lines, -32 lines 0 comments Download
M services/service_manager/public/tools/test/service_test.gni View 1 chunk +1 line, -1 line 0 comments Download
M services/service_manager/tests/BUILD.gn View 4 chunks +3 lines, -18 lines 0 comments Download
D services/service_manager/tests/run_all_unittests.cc View 1 chunk +0 lines, -39 lines 0 comments Download
M services/service_manager/tests/shutdown/BUILD.gn View 3 chunks +0 lines, -7 lines 0 comments Download
A services/test/BUILD.gn View 1 1 chunk +17 lines, -0 lines 0 comments Download
A + services/test/run_all_unittests.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M services/ui/common/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/common/run_all_service_tests.cc View 2 chunks +1 line, -2 lines 0 comments Download
M services/video_capture/BUILD.gn View 5 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
Ken Rockot(use gerrit already)
TBRing because I don't think there's anything interesting here
3 years, 10 months ago (2017-01-26 23:36:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2658063003/1
3 years, 10 months ago (2017-01-26 23:37:31 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/379226)
3 years, 10 months ago (2017-01-27 01:11:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2658063003/20001
3 years, 10 months ago (2017-01-27 02:53:38 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/0f7b4ea0709c59fbd53c222603a19055b98cee65
3 years, 10 months ago (2017-01-27 05:06:44 UTC) #16
Ben Goodger (Google)
3 years, 10 months ago (2017-01-27 15:29:05 UTC) #17
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698