Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2658053002: PPC/s390: [TypeFeedbackVector] DeclareGlobals needs a literals array (Closed)

Created:
3 years, 11 months ago by JaideepBajwa
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [TypeFeedbackVector] DeclareGlobals needs a literals array Port d287c8196990b04169d5dc4e9cf6eb03d88d9e47 Original Commit Message: [RELAND with one change: until literal arrays are rooted in the outer feedback vector (coming in the next days), the runtime-scope.cc change is held off.] When a function is declared in global scope, the closure is created by the DeclareGlobals runtime service. It needs a pointer to the literals array, already allocated in the feedback vector. This fixes a bug where it's behavior wasn't in sync with CreateClosure, which accepts the literals from the vector. This enables a follow-on performance improvement in the CompileLazy builtin. R=mvstanton@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=680637 LOG=N Review-Url: https://codereview.chromium.org/2658053002 Cr-Commit-Position: refs/heads/master@{#42705} Committed: https://chromium.googlesource.com/v8/v8/+/842748006dfb92b46bf2dcb2b1ac64f75c355324

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M src/full-codegen/ppc/full-codegen-ppc.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
JaideepBajwa
ptal
3 years, 11 months ago (2017-01-26 15:09:46 UTC) #1
john.yan
lgtm
3 years, 11 months ago (2017-01-26 15:11:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2658053002/1
3 years, 11 months ago (2017-01-26 15:11:24 UTC) #4
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 15:43:04 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/842748006dfb92b46bf2dcb2b1ac64f75c3...

Powered by Google App Engine
This is Rietveld 408576698