Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 2658023005: Remove macros that combine DCHECK with other expressions via the comma operator. (Closed)

Created:
3 years, 10 months ago by dcheng
Modified:
3 years, 10 months ago
Reviewers:
DaleCurtis, ddorwin
CC:
apacible+watch_chromium.org, chromium-reviews, erickung+watch_chromium.org, feature-media-reviews_chromium.org, miu+watch_chromium.org, xjz+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove macros that combine DCHECK with other expressions via the comma operator. Constructs like this make it harder to tweak how the DCHECK macro works. BUG=684105 Review-Url: https://codereview.chromium.org/2658023005 Cr-Commit-Position: refs/heads/master@{#446748} Committed: https://chromium.googlesource.com/chromium/src/+/37b415b92e8873dad49d71be1c7562319926a3c5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -15 lines) Patch
M media/blink/webmediaplayer_impl.cc View 6 chunks +12 lines, -15 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
dcheng
3 years, 10 months ago (2017-01-27 00:21:41 UTC) #3
ddorwin
>>> dalecurtis
3 years, 10 months ago (2017-01-27 01:48:52 UTC) #8
DaleCurtis
Hmm, don't remember WMPI extending SupportsWeakPtr, we should probably nuke that; this lgtm otherwise though.
3 years, 10 months ago (2017-01-27 18:53:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2658023005/1
3 years, 10 months ago (2017-01-27 19:19:16 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 20:18:22 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/37b415b92e8873dad49d71be1c75...

Powered by Google App Engine
This is Rietveld 408576698