Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issue 2658023004: 🏠 Back button closes bottom sheet if open (Closed)

Created:
3 years, 11 months ago by mdjones
Modified:
3 years, 10 months ago
Reviewers:
gone
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Home] Back button closes bottom sheet if open Before the back button triggers a back navigation, the bottom sheet will be checked first and closed if open. BUG=671361 Review-Url: https://codereview.chromium.org/2658023004 Cr-Commit-Position: refs/heads/master@{#447330} Committed: https://chromium.googlesource.com/chromium/src/+/272e53115aa8395317d15f7a4c976122c1651a58

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java View 2 chunks +8 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (7 generated)
mdjones
A bit of polish, ptal
3 years, 11 months ago (2017-01-26 21:46:25 UTC) #3
gone
lgtm
3 years, 11 months ago (2017-01-26 21:48:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2658023004/1
3 years, 10 months ago (2017-01-31 17:11:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2658023004/1
3 years, 10 months ago (2017-01-31 18:28:02 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 21:17:08 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/272e53115aa8395317d15f7a4c97...

Powered by Google App Engine
This is Rietveld 408576698