Add a fixed delay in history before opening tool menu

ios/chrome/browser/ui/history/history_ui_egtest.mm

Index: ios/chrome/browser/ui/history/history_ui_egtest.mm
diff --git a/ios/chrome/browser/ui/history/history_ui_egtest.mm b/ios/chrome/browser/ui/history/history_ui_egtest.mm
index 789923a87d8c4509e37650db4f6c7d855a378c30..049ce4cb6fcdab29b8600070063e91c2de2ba3f2 100644
--- a/ios/chrome/browser/ui/history/history_ui_egtest.mm
+++ b/ios/chrome/browser/ui/history/history_ui_egtest.mm
@@ -475,6 +475,14 @@ void MockSignIn() {
 }
 
 - (void)openHistoryPanel {
+  // TODO:(crbug.com/685570) Fix the tap instead of adding a delay.

[lpromero, 2017/01/26 10:15:53]

The style if "// TODO(crbug.com/685570): Fix…" 

[gambard, 2017/01/26 10:29:54]

Done.

+  GREYCondition* myCondition = [GREYCondition
+      conditionWithName:@"Delay to ensure the toolbar menu can be opened"
+                  block:^BOOL {
+                    return NO;
+                  }];
+  [myCondition waitWithTimeout:0.5];

[lpromero, 2017/01/26 10:17:07]

How many tests do we have? Adding 0.5 seconds to almost each is pretty costly.

Locally did you reproduce breakage/flakiness, fixed by this? Can you try smaller
values?

[gambard, 2017/01/26 10:19:04]

I will add them to the failing tests only. There is 2 or 3 of them, so the cost
should be manageable.

+
   [ChromeEarlGreyUI openToolsMenu];
   [[EarlGrey selectElementWithMatcher:HistoryButton()]
       performAction:grey_tap()];