[parser] Skipping inner funcs: add variable names into the data for test purposes.

[parser] Skipping inner funcs: add variable names into the data for test purposes.

(Only in debug mode.)

BUG=v8:5516
Review-Url: https://codereview.chromium.org/2657943003
Cr-Commit-Position: refs/heads/master@{#42696}
Committed: https://chromium.googlesource.com/v8/v8/+/03e438110607f7b904628bd47f0d0c657943e3b3

[marja, 2017-01-26 11:55:38]

The CQ bit was checked by marja@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 11:55:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[marja, 2017-01-26 11:56:30]

marja@chromium.org changed reviewers:
+ vogelheim@chromium.org

[marja, 2017-01-26 11:56:30]

ptal

[marja, 2017-01-26 11:59:19]

https://codereview.chromium.org/2657943003/diff/1/src/parsing/preparsed-scope...
File src/parsing/preparsed-scope-data.cc (right):

https://codereview.chromium.org/2657943003/diff/1/src/parsing/preparsed-scope...
src/parsing/preparsed-scope-data.cc:8: #include "src/objects-inl.h"
This is needed because by including variables.h, this file pulls in the
inl-include mess where files don't include each other even if they use each
other. The mess needs to be resolved at the .cc level by pulling in the missing
include.

[vogelheim, 2017-01-26 12:14:07]

lgtm

https://codereview.chromium.org/2657943003/diff/1/src/parsing/preparsed-scope...
File src/parsing/preparsed-scope-data.cc (right):

https://codereview.chromium.org/2657943003/diff/1/src/parsing/preparsed-scope...
src/parsing/preparsed-scope-data.cc:8: #include "src/objects-inl.h"
On 2017/01/26 11:59:18, marja wrote:
> This is needed because by including variables.h, this file pulls in the
> inl-include mess where files don't include each other even if they use each
> other. The mess needs to be resolved at the .cc level by pulling in the
missing
> include.

Acknowledged.

https://codereview.chromium.org/2657943003/diff/1/src/parsing/preparsed-scope...
src/parsing/preparsed-scope-data.cc:41: void
PreParsedScopeData::ScopeScope::AddVariable(Variable* var) {
This is really MaybeAddVariable now. Or maybe some name that indicates it will
only add some of those?

https://codereview.chromium.org/2657943003/diff/1/src/parsing/preparsed-scope...
src/parsing/preparsed-scope-data.cc:48:
data_->backing_store_.push_back(name->raw_data()[i]);
fyi: I plan on abolishing AstRawString::raw_data... I don't really have a good
proposal of what else to do here, though.

[marja, 2017-01-26 12:22:21]

thanks for review!

https://codereview.chromium.org/2657943003/diff/1/src/parsing/preparsed-scope...
File src/parsing/preparsed-scope-data.cc (right):

https://codereview.chromium.org/2657943003/diff/1/src/parsing/preparsed-scope...
src/parsing/preparsed-scope-data.cc:41: void
PreParsedScopeData::ScopeScope::AddVariable(Variable* var) {
On 2017/01/26 12:14:07, vogelheim wrote:
> This is really MaybeAddVariable now. Or maybe some name that indicates it will
> only add some of those?

Changed to MaybeAddVariable; not super fond of the name but can't think of
anything better now.

https://codereview.chromium.org/2657943003/diff/1/src/parsing/preparsed-scope...
src/parsing/preparsed-scope-data.cc:48:
data_->backing_store_.push_back(name->raw_data()[i]);
On 2017/01/26 12:14:07, vogelheim wrote:
> fyi: I plan on abolishing AstRawString::raw_data... I don't really have a good
> proposal of what else to do here, though.

That's cool, I suppose you'll still have at least some debug-mode thing which
can retrieve the raw bytes.

[marja, 2017-01-26 12:22:24]

The CQ bit was checked by marja@chromium.org

[marja, 2017-01-26 12:22:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
vogelheim@chromium.org
Link to the patchset: https://codereview.chromium.org/2657943003/#ps20001
(title: "code review (vogelheim@)")

[commit-bot: I haz the power, 2017-01-26 12:22:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 12:55:54]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485433344997150,
"parent_rev": "439a8edcf77947777c5c757b0dec0363d9446093", "commit_rev":
"03e438110607f7b904628bd47f0d0c657943e3b3"}

[commit-bot: I haz the power, 2017-01-26 12:56:00]

Description was changed from

==========
[parser] Skipping inner funcs: add variable names into the data for test
purposes.

(Only in debug mode.)

BUG=v8:5516
==========

to

==========
[parser] Skipping inner funcs: add variable names into the data for test
purposes.

(Only in debug mode.)

BUG=v8:5516

Review-Url: https://codereview.chromium.org/2657943003
Cr-Commit-Position: refs/heads/master@{#42696}
Committed:
https://chromium.googlesource.com/v8/v8/+/03e438110607f7b904628bd47f0d0c65794...
==========

[commit-bot: I haz the power, 2017-01-26 12:56:01]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/03e438110607f7b904628bd47f0d0c65794...