Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2657933003: Exposes Symbol.toPrimitive in C++ APIs as Symbol::GetToPrimitive. (Closed)

Created:
3 years, 11 months ago by Yuki
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Exposes Symbol.toPrimitive in C++ APIs as Symbol::GetToPrimitive. As Blink needs to set Symbol.toPrimitive, exposes the symbol in C++ APIs as Symbol::GetToPrimitive. BUG=chromium:680409 Review-Url: https://codereview.chromium.org/2657933003 Cr-Commit-Position: refs/heads/master@{#42724} Committed: https://chromium.googlesource.com/v8/v8/+/34bee46b0be6afc06f254ec0debd4b868443a649

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed a review comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M include/v8.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/api.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Yuki
Could you review this CL?
3 years, 11 months ago (2017-01-26 15:11:16 UTC) #4
jochen (gone - plz use gerrit)
lgtm with nit https://codereview.chromium.org/2657933003/diff/1/src/api.cc File src/api.cc (right): https://codereview.chromium.org/2657933003/diff/1/src/api.cc#newcode7843 src/api.cc:7843: just one empty line between functions
3 years, 10 months ago (2017-01-27 04:08:07 UTC) #7
Yuki
https://codereview.chromium.org/2657933003/diff/1/src/api.cc File src/api.cc (right): https://codereview.chromium.org/2657933003/diff/1/src/api.cc#newcode7843 src/api.cc:7843: On 2017/01/27 04:08:07, jochen (travelling til Feb 4) wrote: ...
3 years, 10 months ago (2017-01-27 06:53:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2657933003/20001
3 years, 10 months ago (2017-01-27 06:53:40 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 07:29:21 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/34bee46b0be6afc06f254ec0debd4b86844...

Powered by Google App Engine
This is Rietveld 408576698