Source/core/dom/MutationObserverRegistration.h - Issue 265793017: Oilpan: move node/element rare data objects to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/MutationObserverRegistration.h

Issue 265793017: Oilpan: move node/element rare data objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebased + assert for Nodes having no renderer on destruction. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/MutationObserverRegistration.h

diff --git a/Source/core/dom/MutationObserverRegistration.h b/Source/core/dom/MutationObserverRegistration.h

index 7668c09b115c78a31a385dd3a26cf3a0bc468d6c..42d3d15004d4052a1f3febfbdd6912e34501da31 100644

--- a/Source/core/dom/MutationObserverRegistration.h

+++ b/Source/core/dom/MutationObserverRegistration.h

@@ -69,7 +69,10 @@ private:

MutationObserverRegistration(MutationObserver&, Node&, MutationObserverOptions, const HashSet<AtomicString>& attributeFilter);

RefPtrWillBeMember<MutationObserver> m_observer;

- Node& m_registrationNode;

+ RawPtrWillBeMember<Node> m_registrationNode;

+ // FIXME: Oilpan: once a Member reference will keep a Node

+ // and its tree alive, this keep-alive RefPtr can be

+ // removed for Oilpan builds.

RefPtr<Node> m_registrationNodeKeepAlive;

typedef HashSet<RefPtr<Node> > NodeHashSet;

OwnPtr<NodeHashSet> m_transientRegistrationNodes;

« Source/core/dom/MutationObserver.cpp ('K') | « Source/core/dom/MutationObserver.cpp ('k') | Source/core/dom/MutationObserverRegistration.cpp » ('j') | Source/core/dom/Node.cpp » ('J')