Source/core/dom/MutationObserverRegistration.h - Issue 265793017: Oilpan: move node/element rare data objects to the heap.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/dom/MutationObserverRegistration.h

Issue 265793017: Oilpan: move node/element rare data objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebased + assert for Nodes having no renderer on destruction. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2011 Google Inc. All rights reserved.	2 * Copyright (C) 2011 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 51 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
62 void addRegistrationNodesToSet(HashSet<Node*>&) const;	62 void addRegistrationNodesToSet(HashSet<Node*>&) const;

63	63

64 void trace(Visitor*);	64 void trace(Visitor*);

65	65

66 void dispose();	66 void dispose();

67	67

68 private:	68 private:

69 MutationObserverRegistration(MutationObserver&, Node&, MutationObserverOptio ns, const HashSet<AtomicString>& attributeFilter);	69 MutationObserverRegistration(MutationObserver&, Node&, MutationObserverOptio ns, const HashSet<AtomicString>& attributeFilter);

70	70

71 RefPtrWillBeMember<MutationObserver> m_observer;	71 RefPtrWillBeMember<MutationObserver> m_observer;

72 Node& m_registrationNode;	72 RawPtrWillBeMember<Node> m_registrationNode;

	73 // FIXME: Oilpan: once a Member reference will keep a Node

	74 // and its tree alive, this keep-alive RefPtr can be

	75 // removed for Oilpan builds.

73 RefPtr<Node> m_registrationNodeKeepAlive;	76 RefPtr<Node> m_registrationNodeKeepAlive;

74 typedef HashSet<RefPtr<Node> > NodeHashSet;	77 typedef HashSet<RefPtr<Node> > NodeHashSet;

75 OwnPtr<NodeHashSet> m_transientRegistrationNodes;	78 OwnPtr<NodeHashSet> m_transientRegistrationNodes;

76	79

77 MutationObserverOptions m_options;	80 MutationObserverOptions m_options;

78 HashSet<AtomicString> m_attributeFilter;	81 HashSet<AtomicString> m_attributeFilter;

79 };	82 };

80	83

81 } // namespace WebCore	84 } // namespace WebCore

82	85

83 #endif // MutationObserverRegistration_h	86 #endif // MutationObserverRegistration_h

OLD	NEW

« Source/core/dom/MutationObserver.cpp ('K') | « Source/core/dom/MutationObserver.cpp ('k') | Source/core/dom/MutationObserverRegistration.cpp » ('j') | Source/core/dom/Node.cpp » ('J')