Source/core/dom/MutationObserverRegistration.h - Issue 265793017: Oilpan: move node/element rare data objects to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/MutationObserverRegistration.h

Issue 265793017: Oilpan: move node/element rare data objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebased + have MutationObserver keep a weak ref to registrations Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/dom/ElementRareData.h ('K') | « Source/core/dom/MutationObserver.cpp ('k') | Source/core/dom/MutationObserverRegistration.cpp » ('j') | Source/core/dom/MutationObserverRegistration.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/dom/MutationObserverRegistration.h

diff --git a/Source/core/dom/MutationObserverRegistration.h b/Source/core/dom/MutationObserverRegistration.h

index 7668c09b115c78a31a385dd3a26cf3a0bc468d6c..7af8e85137f256db9dd7511c2f99d56d5aaac400 100644

--- a/Source/core/dom/MutationObserverRegistration.h

+++ b/Source/core/dom/MutationObserverRegistration.h

@@ -43,7 +43,7 @@ class QualifiedName;

class MutationObserverRegistration FINAL : public NoBaseWillBeGarbageCollectedFinalized<MutationObserverRegistration> {

public:

- static PassOwnPtrWillBeRawPtr<MutationObserverRegistration> create(MutationObserver&, Node&, MutationObserverOptions, const HashSet<AtomicString>& attributeFilter);

+ static PassOwnPtrWillBeRawPtr<MutationObserverRegistration> create(MutationObserver&, Node*, MutationObserverOptions, const HashSet<AtomicString>& attributeFilter);

~MutationObserverRegistration();

void resetObservation(MutationObserverOptions, const HashSet<AtomicString>& attributeFilter);

@@ -66,11 +66,11 @@ public:

void dispose();

private:

- MutationObserverRegistration(MutationObserver&, Node&, MutationObserverOptions, const HashSet<AtomicString>& attributeFilter);

+ MutationObserverRegistration(MutationObserver&, Node*, MutationObserverOptions, const HashSet<AtomicString>& attributeFilter);

RefPtrWillBeMember<MutationObserver> m_observer;

- Node& m_registrationNode;

- RefPtr<Node> m_registrationNodeKeepAlive;

+ RawPtrWillBeWeakMember<Node> m_registrationNode;

+ RefPtrWillBeMember<Node> m_registrationNodeKeepAlive;

typedef HashSet<RefPtr<Node> > NodeHashSet;

OwnPtr<NodeHashSet> m_transientRegistrationNodes;

haraken 2014/05/08 04:14:00 This could be OwnPtrWillBeMember<WillBeHeapHashSet