Source/core/dom/MutationObserver.cpp - Issue 265793017: Oilpan: move node/element rare data objects to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/MutationObserver.cpp

Issue 265793017: Oilpan: move node/element rare data objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebased + have MutationObserver keep a weak ref to registrations Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/dom/ElementRareData.h ('K') | « Source/core/dom/MutationObserver.h ('k') | Source/core/dom/MutationObserverRegistration.h » ('j') | Source/core/dom/MutationObserverRegistration.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/dom/MutationObserver.cpp

diff --git a/Source/core/dom/MutationObserver.cpp b/Source/core/dom/MutationObserver.cpp

index d8ea3ddffc2835eb2ad3c661defa1b4dfb5b6f56..e36a1a7b243262d77d7a3ee733d7d72b8497f112 100644

--- a/Source/core/dom/MutationObserver.cpp

+++ b/Source/core/dom/MutationObserver.cpp

@@ -70,7 +70,9 @@ MutationObserver::MutationObserver(PassOwnPtr<MutationCallback> callback)

MutationObserver::~MutationObserver()

{

+#if !ENABLE(OILPAN)

ASSERT(m_registrations.isEmpty());

+#endif

if (!m_records.isEmpty())

InspectorInstrumentation::didClearAllMutationRecords(m_callback->executionContext(), this);

}