Source/core/html/forms/TextFieldInputType.cpp - Issue 265793017: Oilpan: move node/element rare data objects to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/forms/TextFieldInputType.cpp

Issue 265793017: Oilpan: move node/element rare data objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebased + EventHandler.cpp oilpan compile fix Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/forms/TextFieldInputType.cpp

diff --git a/Source/core/html/forms/TextFieldInputType.cpp b/Source/core/html/forms/TextFieldInputType.cpp

index 1b78abe81c6802df9dd34458a9f75859217cdbb0..b094159a74c3abfa1b3c91dfe4a68f20c93cc170 100644

--- a/Source/core/html/forms/TextFieldInputType.cpp

+++ b/Source/core/html/forms/TextFieldInputType.cpp

@@ -115,8 +115,10 @@ TextFieldInputType::TextFieldInputType(HTMLInputElement& element)

TextFieldInputType::~TextFieldInputType()

{

+#if !ENABLE(OILPAN)

if (SpinButtonElement* spinButton = spinButtonElement())

spinButton->removeSpinButtonOwner();

+#endif

haraken 2014/05/04 01:46:24 This part is not related to this CL, and should ha

sof 2014/05/04 18:59:22 The reason why it's here in this CL is that it cau

}

SpinButtonElement* TextFieldInputType::spinButtonElement() const

« Source/core/dom/shadow/ElementShadow.cpp ('K') | « Source/core/dom/shadow/ShadowRoot.cpp ('k') | Source/core/page/EventHandler.cpp » ('j') | Source/core/page/EventHandler.cpp » ('J')