Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Side by Side Diff: Source/core/html/forms/TextFieldInputType.cpp

Issue 265793017: Oilpan: move node/element rare data objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebased + EventHandler.cpp oilpan compile fix Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * Copyright (C) 2011 Apple Inc. All rights reserved. 3 * Copyright (C) 2011 Apple Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 108
109 }; 109 };
110 110
111 TextFieldInputType::TextFieldInputType(HTMLInputElement& element) 111 TextFieldInputType::TextFieldInputType(HTMLInputElement& element)
112 : InputType(element) 112 : InputType(element)
113 { 113 {
114 } 114 }
115 115
116 TextFieldInputType::~TextFieldInputType() 116 TextFieldInputType::~TextFieldInputType()
117 { 117 {
118 #if !ENABLE(OILPAN)
118 if (SpinButtonElement* spinButton = spinButtonElement()) 119 if (SpinButtonElement* spinButton = spinButtonElement())
119 spinButton->removeSpinButtonOwner(); 120 spinButton->removeSpinButtonOwner();
121 #endif
haraken 2014/05/04 01:46:24 This part is not related to this CL, and should ha
sof 2014/05/04 18:59:22 The reason why it's here in this CL is that it cau
120 } 122 }
121 123
122 SpinButtonElement* TextFieldInputType::spinButtonElement() const 124 SpinButtonElement* TextFieldInputType::spinButtonElement() const
123 { 125 {
124 return toSpinButtonElement(element().userAgentShadowRoot()->getElementById(S hadowElementNames::spinButton())); 126 return toSpinButtonElement(element().userAgentShadowRoot()->getElementById(S hadowElementNames::spinButton()));
125 } 127 }
126 128
127 bool TextFieldInputType::shouldShowFocusRingOnMouseFocus() const 129 bool TextFieldInputType::shouldShowFocusRingOnMouseFocus() const
128 { 130 {
129 return true; 131 return true;
(...skipping 435 matching lines...) Expand 10 before | Expand all | Expand 10 after
565 return shouldSpinButtonRespondToMouseEvents() && element().focused(); 567 return shouldSpinButtonRespondToMouseEvents() && element().focused();
566 } 568 }
567 569
568 void TextFieldInputType::spinButtonDidReleaseMouseCapture(SpinButtonElement::Eve ntDispatch eventDispatch) 570 void TextFieldInputType::spinButtonDidReleaseMouseCapture(SpinButtonElement::Eve ntDispatch eventDispatch)
569 { 571 {
570 if (eventDispatch == SpinButtonElement::EventDispatchAllowed) 572 if (eventDispatch == SpinButtonElement::EventDispatchAllowed)
571 element().dispatchFormControlChangeEvent(); 573 element().dispatchFormControlChangeEvent();
572 } 574 }
573 575
574 } // namespace WebCore 576 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698