Factor out core logic from OnCanAccessFile() and add tests for it

Factor out core logic from OnCanAccessFile() and add tests for it

OnCanAccessFile() had platform-specific logic to decide which paths
are allowed to access via file: schema, that had not tests.
This patch factors out the logic and adds tests for it.

Before adding more code to the logic, I wanted added tests for it.

BUG=677933
TEST=the new tests pass

Review-Url: https://codereview.chromium.org/2657903005
Cr-Commit-Position: refs/heads/master@{#446617}
Committed: https://chromium.googlesource.com/chromium/src/+/7c5360584c37d4d21a46f1c410e1d0d036494bf8

[satorux1, 2017-01-26 02:29:18]

The CQ bit was checked by satorux@chromium.org to run a CQ dry run

[satorux1, 2017-01-26 04:28:13]

The CQ bit was checked by satorux@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 04:28:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[satorux1, 2017-01-26 04:30:04]

satorux@chromium.org changed reviewers:
+ eroman@chromium.org

[commit-bot: I haz the power, 2017-01-26 04:50:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 04:50:31]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[satorux1, 2017-01-26 07:06:34]

The CQ bit was checked by satorux@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 07:06:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 07:58:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 07:58:00]

Dry run: This issue passed the CQ dry run.

[eroman, 2017-01-27 01:21:49]

LGTM, thanks for the tests!

https://codereview.chromium.org/2657903005/diff/40001/chrome/browser/net/chro...
File chrome/browser/net/chrome_network_delegate_unittest.cc (right):

https://codereview.chromium.org/2657903005/diff/40001/chrome/browser/net/chro...
chrome/browser/net/chrome_network_delegate_unittest.cc:545: return;
Is this return needed? (it looks like there won't be any other code executed in
this case anyway).

[satorux1, 2017-01-27 06:23:35]

https://codereview.chromium.org/2657903005/diff/40001/chrome/browser/net/chro...
File chrome/browser/net/chrome_network_delegate_unittest.cc (right):

https://codereview.chromium.org/2657903005/diff/40001/chrome/browser/net/chro...
chrome/browser/net/chrome_network_delegate_unittest.cc:545: return;
good point. removed!

[satorux1, 2017-01-27 06:25:09]

The CQ bit was checked by satorux@chromium.org

[satorux1, 2017-01-27 06:25:09]

The patchset sent to the CQ was uploaded after l-g-t-m from eroman@chromium.org
Link to the patchset: https://codereview.chromium.org/2657903005/#ps80001
(title: "address comments")

[commit-bot: I haz the power, 2017-01-27 06:25:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 07:24:33]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1485498309148030,
"parent_rev": "e216bcff410cfdf384b832ced06d2da0fcafcaf3", "commit_rev":
"7c5360584c37d4d21a46f1c410e1d0d036494bf8"}

[commit-bot: I haz the power, 2017-01-27 07:25:22]

Description was changed from

==========
Factor out core logic from OnCanAccessFile() and add tests for it

OnCanAccessFile() had platform-specific logic to decide which paths
are allowed to access via file: schema, that had not tests.
This patch factors out the logic and adds tests for it.

Before adding more code to the logic, I wanted added tests for it.

BUG=677933
TEST=the new tests pass
==========

to

==========
Factor out core logic from OnCanAccessFile() and add tests for it

OnCanAccessFile() had platform-specific logic to decide which paths
are allowed to access via file: schema, that had not tests.
This patch factors out the logic and adds tests for it.

Before adding more code to the logic, I wanted added tests for it.

BUG=677933
TEST=the new tests pass

Review-Url: https://codereview.chromium.org/2657903005
Cr-Commit-Position: refs/heads/master@{#446617}
Committed:
https://chromium.googlesource.com/chromium/src/+/7c5360584c37d4d21a46f1c410e1...
==========

[commit-bot: I haz the power, 2017-01-27 07:25:22]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/7c5360584c37d4d21a46f1c410e1...