Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2657893002: DevTools: temporarily revert Timeline->Performance rename. (Closed)

Created:
3 years, 11 months ago by pfeldman
Modified:
3 years, 11 months ago
Reviewers:
caseq
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: temporarily revert Timeline->Performance rename. BUG=685294 Review-Url: https://codereview.chromium.org/2657893002 Cr-Commit-Position: refs/heads/master@{#446141} Committed: https://chromium.googlesource.com/chromium/src/+/965cfcc7364062072a9dd574e39073f0f0d67abe

Patch Set 1 #

Patch Set 2 : +tests #

Patch Set 3 : Introduce progress monitor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -51 lines) Patch
M third_party/WebKit/LayoutTests/inspector/profiler/cpu-profiler-profile-removal.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/profiler/cpu-profiler-save-load.html View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/profiler/cpu-profiler-stopped-removed-race.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/profiler/profiler-test.js View 1 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/user-metrics.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/user-metrics-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/HeapProfilerPanel.js View 1 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/module.json View 1 chunk +1 line, -20 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/profilesPanel.css View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js View 1 1 chunk +2 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/module.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/ShortcutsScreen.js View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
pfeldman
3 years, 11 months ago (2017-01-25 19:01:51 UTC) #2
caseq
lgtm
3 years, 11 months ago (2017-01-25 19:05:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2657893002/40001
3 years, 11 months ago (2017-01-25 19:19:31 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/220122)
3 years, 11 months ago (2017-01-25 20:56:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2657893002/40001
3 years, 11 months ago (2017-01-25 21:15:17 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 22:22:21 UTC) #13
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/965cfcc7364062072a9dd574e390...

Powered by Google App Engine
This is Rietveld 408576698