Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 2657883002: Add finch configuration for the OfflinePagesSvelte finch test. (Closed)

Created:
3 years, 11 months ago by Pete Williamson
Modified:
3 years, 10 months ago
Reviewers:
jianli, Steven Holte
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add finch configuration for the OfflinePagesSvelte finch test. BUG=682525 Review-Url: https://codereview.chromium.org/2657883002 Cr-Commit-Position: refs/heads/master@{#447049} Committed: https://chromium.googlesource.com/chromium/src/+/3532d6ed361f9633973673c9c49ca7bbc8f1e4e4

Patch Set 1 #

Total comments: 3

Patch Set 2 : formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M testing/variations/fieldtrial_testing_config.json View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
Pete Williamson
This is the chromium part of the configuration for the OfflinePagesSvelte finch test.
3 years, 11 months ago (2017-01-25 19:00:16 UTC) #2
jianli
Please ask a Finch reviewer to review and approve it. https://codereview.chromium.org/2657883002/diff/1/testing/variations/fieldtrial_testing_config.json File testing/variations/fieldtrial_testing_config.json (right): https://codereview.chromium.org/2657883002/diff/1/testing/variations/fieldtrial_testing_config.json#newcode1329 ...
3 years, 11 months ago (2017-01-26 01:32:34 UTC) #3
Pete Williamson
Adding holte for OWNERS review.
3 years, 11 months ago (2017-01-26 01:48:26 UTC) #5
Steven Holte
https://codereview.chromium.org/2657883002/diff/1/testing/variations/fieldtrial_testing_config.json File testing/variations/fieldtrial_testing_config.json (right): https://codereview.chromium.org/2657883002/diff/1/testing/variations/fieldtrial_testing_config.json#newcode1329 testing/variations/fieldtrial_testing_config.json:1329: "OfflinePagesSvelte" On 2017/01/26 01:32:34, jianli wrote: > Should this ...
3 years, 11 months ago (2017-01-26 21:59:39 UTC) #6
Pete Williamson
https://codereview.chromium.org/2657883002/diff/1/testing/variations/fieldtrial_testing_config.json File testing/variations/fieldtrial_testing_config.json (right): https://codereview.chromium.org/2657883002/diff/1/testing/variations/fieldtrial_testing_config.json#newcode1329 testing/variations/fieldtrial_testing_config.json:1329: "OfflinePagesSvelte" On 2017/01/26 21:59:39, Steven Holte wrote: > On ...
3 years, 10 months ago (2017-01-28 01:29:13 UTC) #7
Steven Holte
lgtm
3 years, 10 months ago (2017-01-30 18:59:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2657883002/20001
3 years, 10 months ago (2017-01-30 19:18:56 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 20:20:00 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3532d6ed361f9633973673c9c49c...

Powered by Google App Engine
This is Rietveld 408576698