Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2657873003: cc: Add more seriliazation perf test cases (Closed)

Created:
3 years, 11 months ago by weiliangc
Modified:
3 years, 10 months ago
Reviewers:
danakj, Fady Samuel, fsamuel
CC:
cc-bugs_chromium.org, chromium-reviews, danakj
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Add more seriliazation perf test cases Number of SharedQuadState would affect serialization test results too. Add more test cases for that. Added modifier in PrintResult to reflect this option. Also changed and renamed two previous test that are repeated and incorrectly named. BUG= R=fsamuel CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2657873003 Cr-Commit-Position: refs/heads/master@{#447264} Committed: https://chromium.googlesource.com/chromium/src/+/a02090236d8c8ad6cafcb568bcfeb910fde09d9c

Patch Set 1 #

Total comments: 3

Patch Set 2 : add comments according to review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -30 lines) Patch
M cc/ipc/cc_serialization_perftest.cc View 1 6 chunks +93 lines, -30 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
weiliangc
3 years, 11 months ago (2017-01-25 20:54:37 UTC) #2
Fady Samuel
Could you share some numbers in here? Thanks!
3 years, 11 months ago (2017-01-25 20:57:54 UTC) #4
Fady Samuel
Could you share some numbers in here? Thanks!
3 years, 11 months ago (2017-01-25 20:57:55 UTC) #5
weiliangc
On 2017/01/25 at 20:57:55, fsamuel wrote: > Could you share some numbers in here? Thanks! ...
3 years, 11 months ago (2017-01-25 21:03:42 UTC) #6
weiliangc
Also added comment to indicate the two renamed tests https://codereview.chromium.org/2657873003/diff/1/cc/ipc/cc_serialization_perftest.cc File cc/ipc/cc_serialization_perftest.cc (right): https://codereview.chromium.org/2657873003/diff/1/cc/ipc/cc_serialization_perftest.cc#newcode276 cc/ipc/cc_serialization_perftest.cc:276: ...
3 years, 11 months ago (2017-01-25 21:13:45 UTC) #8
Fady Samuel
LGTM + request for comment. Then pass this along to danakj@ I guess. Thanks! https://codereview.chromium.org/2657873003/diff/1/cc/ipc/cc_serialization_perftest.cc ...
3 years, 11 months ago (2017-01-25 21:15:53 UTC) #9
danakj
LGTM
3 years, 10 months ago (2017-01-31 15:40:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2657873003/20001
3 years, 10 months ago (2017-01-31 17:37:23 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 17:53:23 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a02090236d8c8ad6cafcb568bcfe...

Powered by Google App Engine
This is Rietveld 408576698