Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 2657873002: [cipd] use new pin types in common (Closed)

Created:
3 years, 11 months ago by iannucci
Modified:
3 years, 11 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : remove buildinstanceidmap #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -65 lines) Patch
M cipd/client/cipd/client.go View 1 2 9 chunks +13 lines, -22 lines 0 comments Download
M cipd/client/cipd/client_test.go View 14 chunks +24 lines, -24 lines 0 comments Download
M cipd/client/cipd/ensure/file.go View 2 chunks +2 lines, -2 lines 0 comments Download
M cipd/client/cipd/ensure/good_test.go View 6 chunks +6 lines, -6 lines 0 comments Download
M cipd/client/cipd/local/deployer.go View 4 chunks +7 lines, -7 lines 0 comments Download
M cipd/client/cipd/local/deployer_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M cipd/client/cipd/remote.go View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
iannucci
3 years, 11 months ago (2017-01-25 18:33:23 UTC) #1
Vadim Sh.
lgtm
3 years, 11 months ago (2017-01-25 18:54:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2657873002/20001
3 years, 11 months ago (2017-01-25 20:37:17 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: Luci-go Linux Trusty 32-on-64 Tester on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/33f02a73bd00f610) ...
3 years, 11 months ago (2017-01-25 20:39:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2657873002/40001
3 years, 11 months ago (2017-01-25 20:59:23 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 21:06:29 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://github.com/luci/luci-go/commit/e3bb2f1f38d3ddef70ad0a9612c042546e0a003b

Powered by Google App Engine
This is Rietveld 408576698