Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Issue 2657853004: Improve vim's 'gf' for BUILD.gn files (Closed)

Created:
3 years, 11 months ago by Nate Fischer
Modified:
3 years, 11 months ago
Reviewers:
scottmg
CC:
agrieve+watch_chromium.org, chromium-reviews, Dirk Pranke, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve vim's 'gf' for BUILD.gn files If vim-maktaba is installed, vim will use it during the 'gf' command in GN files. If maktaba is not installed, the plugin uses a fallback approach, however this is easily broken with the 'autochdir' setting. BUG= Review-Url: https://codereview.chromium.org/2657853004 Cr-Commit-Position: refs/heads/master@{#446447} Committed: https://chromium.googlesource.com/chromium/src/+/e46620f101019c220a303e6cc82c57c928a677bd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M tools/gn/misc/vim/autoload/gn.vim View 1 chunk +11 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Nate Fischer
PTAL
3 years, 11 months ago (2017-01-26 20:12:13 UTC) #2
scottmg
lgtm
3 years, 11 months ago (2017-01-26 20:36:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2657853004/1
3 years, 11 months ago (2017-01-26 21:06:03 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 21:14:25 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e46620f101019c220a303e6cc82c...

Powered by Google App Engine
This is Rietveld 408576698