Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 2657853002: Fix traverseNonCompositingDescendantsInPaintOrder for float-under-inline cases (Closed)

Created:
3 years, 11 months ago by Xianzhu
Modified:
3 years, 11 months ago
Reviewers:
Xianzhu
CC:
chromium-reviews, blink-reviews, dshwang, blink-reviews-paint_chromium.org
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Fix traverseNonCompositingDescendantsInPaintOrder for float-under-inline cases We should traverse into composited inlines even if they are stacking context, because there might be floating objects which belong to ancestors in paint order. During traverse for paint invalidation, when we encounter a floating object, we should mark the real painting layer for paint invalidation which may be above the tip of the subtree being traversed. BUG=644144 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 TBR=wangxianzhu@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2639283003 Cr-Original-Commit-Position: refs/heads/master@{#445679} Review-Url: https://codereview.chromium.org/2657853002 Cr-Commit-Position: refs/branch-heads/2987@{#87} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/246f4f0482e90289fd249360c558f9cee734f122

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+246 lines, -23 lines) Patch
M third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp View 6 chunks +54 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ObjectPaintInvalidatorTest.cpp View 2 chunks +192 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2657853002/1
3 years, 11 months ago (2017-01-25 17:55:54 UTC) #2
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 17:59:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/246f4f0482e90289fd249360c558...

Powered by Google App Engine
This is Rietveld 408576698