Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 2657823005: Move //c/b/services/gcm/ to //c/b/gcm/ (Closed)

Created:
10 months, 3 weeks ago by Peter Beverloo
Modified:
10 months, 3 weeks ago
Reviewers:
Nico, Nicolas Zea
CC:
chromium-reviews, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, zea+watch_chromium.org, Peter Beverloo, harkness+watch_chromium.org, johnme+watch_chromium.org, sync-reviews_chromium.org, oshima+watch_chromium.org, mac-reviews_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move //c/b/services/gcm/ to //c/b/gcm/ The `services` directory contains exactly one child directory. BUG= Review-Url: https://codereview.chromium.org/2657823005 Cr-Commit-Position: refs/heads/master@{#446509} Committed: https://chromium.googlesource.com/chromium/src/+/9f4490a30641dcd7710ffca2fd7ff0a3aaad978a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -1025 lines) Patch
M WATCHLISTS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/BUILD.gn View 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/net/wake_on_wifi_connection_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/net/wake_on_wifi_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/net/wake_on_wifi_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/gcm/gcm_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/gcm/gcm_apitest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/instance_id/instance_id_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/instance_id/instance_id_apitest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_gcm_app_handler.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_gcm_app_handler_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/service_worker_apitest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/gcm/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/gcm/fake_gcm_profile_service.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/gcm/fake_gcm_profile_service.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/gcm/gcm_product_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/gcm/gcm_product_util.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/gcm/gcm_profile_service_factory.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/gcm/gcm_profile_service_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/gcm/gcm_profile_service_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/gcm/instance_id/instance_id_profile_service.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/gcm/instance_id/instance_id_profile_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/gcm/instance_id/instance_id_profile_service_factory.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/gcm/instance_id/instance_id_profile_service_factory.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/invalidation/profile_invalidation_provider_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/push_messaging/push_messaging_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/push_messaging/push_messaging_service_factory.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/push_messaging/push_messaging_service_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/push_messaging/push_messaging_service_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/browser/services/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/services/gcm/OWNERS View 1 chunk +0 lines, -5 lines 0 comments Download
D chrome/browser/services/gcm/fake_gcm_profile_service.h View 1 chunk +0 lines, -89 lines 0 comments Download
D chrome/browser/services/gcm/fake_gcm_profile_service.cc View 1 chunk +0 lines, -204 lines 0 comments Download
D chrome/browser/services/gcm/gcm_product_util.h View 1 chunk +0 lines, -30 lines 0 comments Download
D chrome/browser/services/gcm/gcm_product_util.cc View 1 chunk +0 lines, -57 lines 0 comments Download
D chrome/browser/services/gcm/gcm_profile_service_factory.h View 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/browser/services/gcm/gcm_profile_service_factory.cc View 1 chunk +0 lines, -95 lines 0 comments Download
D chrome/browser/services/gcm/gcm_profile_service_unittest.cc View 1 chunk +0 lines, -253 lines 0 comments Download
D chrome/browser/services/gcm/instance_id/instance_id_profile_service.h View 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/browser/services/gcm/instance_id/instance_id_profile_service.cc View 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/browser/services/gcm/instance_id/instance_id_profile_service_factory.h View 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/browser/services/gcm/instance_id/instance_id_profile_service_factory.cc View 1 chunk +0 lines, -56 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/easy_unlock_service_regular.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/gcm_internals_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/BUILD.gn View 6 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Peter Beverloo
+zea
10 months, 3 weeks ago (2017-01-26 17:08:31 UTC) #6
Nicolas Zea
LGTM, thanks!
10 months, 3 weeks ago (2017-01-26 18:35:59 UTC) #7
Peter Beverloo
+thakis for //chrome OWNERS
10 months, 3 weeks ago (2017-01-26 18:44:52 UTC) #9
Nico
lgtm
10 months, 3 weeks ago (2017-01-26 19:10:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2657823005/1
10 months, 3 weeks ago (2017-01-27 00:34:20 UTC) #12
commit-bot: I haz the power
10 months, 3 weeks ago (2017-01-27 00:59:25 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9f4490a30641dcd7710ffca2fd7f...

Powered by Google App Engine
This is Rietveld 0eb02b776