Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2657773006: [modules] Update a test and status file to reflect recent spec changes. (Closed)

Created:
3 years, 10 months ago by neis
Modified:
3 years, 10 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[modules] Update a test and status file to reflect recent spec changes. R=adamk@chromium.org BUG=v8:1569 Review-Url: https://codereview.chromium.org/2657773006 Cr-Commit-Position: refs/heads/master@{#42763} Committed: https://chromium.googlesource.com/v8/v8/+/5ed733737e0241af2bf939fec1f82af24b5a0d52

Patch Set 1 #

Total comments: 2

Patch Set 2 : Move invalid tests to the invalid tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -23 lines) Patch
M test/mjsunit/modules-namespace1.js View 1 chunk +3 lines, -1 line 0 comments Download
M test/test262/test262.status View 1 2 chunks +19 lines, -22 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
neis
3 years, 10 months ago (2017-01-27 15:29:37 UTC) #1
adamk
lgtm https://codereview.chromium.org/2657773006/diff/1/test/test262/test262.status File test/test262/test262.status (right): https://codereview.chromium.org/2657773006/diff/1/test/test262/test262.status#newcode444 test/test262/test262.status:444: # Spec changed, tests need to be updated. ...
3 years, 10 months ago (2017-01-27 16:10:37 UTC) #2
neis
https://codereview.chromium.org/2657773006/diff/1/test/test262/test262.status File test/test262/test262.status (right): https://codereview.chromium.org/2657773006/diff/1/test/test262/test262.status#newcode444 test/test262/test262.status:444: # Spec changed, tests need to be updated. On ...
3 years, 10 months ago (2017-01-30 09:10:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2657773006/20001
3 years, 10 months ago (2017-01-30 09:10:30 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 09:41:21 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/5ed733737e0241af2bf939fec1f82af24b5...

Powered by Google App Engine
This is Rietveld 408576698