Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2657763002: Disable EarlGrey tests that break using webview in current webstate. (Closed)

Created:
3 years, 10 months ago by baxley
Modified:
3 years, 10 months ago
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, asvitkine+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable EarlGrey tests that break using webview in current webstate. Some tests don't work accessing the webview in the current webstate. Previously they retieved the webview via the web controller. BUG=684987 TBR=eugenebut Review-Url: https://codereview.chromium.org/2657763002 Cr-Commit-Position: refs/heads/master@{#445955} Committed: https://chromium.googlesource.com/chromium/src/+/51cffb5bb9c6052a085a621aa38144c47da6146a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm View 1 chunk +2 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/activity_services/activity_service_controller_egtest.mm View 1 chunk +3 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/error_page_egtest.mm View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
baxley
Sorry to disable these, but that's the quickest way to get the tree green for ...
3 years, 10 months ago (2017-01-25 04:10:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2657763002/1
3 years, 10 months ago (2017-01-25 04:11:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/51cffb5bb9c6052a085a621aa38144c47da6146a
3 years, 10 months ago (2017-01-25 05:17:46 UTC) #8
Eugene But (OOO till 7-30)
3 years, 10 months ago (2017-01-25 05:45:49 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698