Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Issue 2657743004: Handle stale m_owner in FrameView::needsScrollbarReconstruction. (Closed)

Created:
3 years, 11 months ago by skobes
Modified:
3 years, 11 months ago
Reviewers:
szager1
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle stale m_owner in FrameView::needsScrollbarReconstruction. If iframe content is replaced by document.write, its LayoutScrollbar can hold a reference to the previous body element. FrameView now detects this situation and reconstructs the scrollbar. This mirrors similar code in PaintLayerScrollableArea added in r352644. BUG=678821 Review-Url: https://codereview.chromium.org/2657743004 Cr-Commit-Position: refs/heads/master@{#446360} Committed: https://chromium.googlesource.com/chromium/src/+/2b2839b3fba03dab76bee97c6aa4eb1ab1ecb836

Patch Set 1 #

Patch Set 2 : remove obsolete comment #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -13 lines) Patch
A third_party/WebKit/LayoutTests/scrollbars/custom-scrollbar-reconstruction-document-write.html View 1 chunk +25 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 2 2 chunks +26 lines, -12 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
skobes
3 years, 11 months ago (2017-01-26 02:44:24 UTC) #5
szager1
lgtm
3 years, 11 months ago (2017-01-26 05:56:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2657743004/40001
3 years, 11 months ago (2017-01-26 15:10:02 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 17:28:30 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/2b2839b3fba03dab76bee97c6aa4...

Powered by Google App Engine
This is Rietveld 408576698