Add sort function helper library.

Add sort function helper library.

Inspired by comments on https://github.com/golang/go/issues/16721.

This will be particularly handy when we get to use a version of go (1.8) which
has `sort.Slice`. But in the mean time, it's at least clearer and quicker than
hand-rolling Less methods (and potentially safer too!).

R=dnj@chromium.org, nodir@chromium.org, vadimsh@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2657733002
Committed: https://github.com/luci/luci-go/commit/80c0aea21b33925fd87eb92ee06e99395c33a5a1

[Vadim Sh., 2017-01-25 03:43:34]

lgtm with nits

https://codereview.chromium.org/2657733002/diff/1/common/data/sortby/sortby.go
File common/data/sortby/sortby.go (right):

https://codereview.chromium.org/2657733002/diff/1/common/data/sortby/sortby.g...
common/data/sortby/sortby.go:12: // elements. Multiple LessFns can be composed
with This and ThenBy to create
what This and ThenBy?

https://codereview.chromium.org/2657733002/diff/1/common/data/sortby/sortby_t...
File common/data/sortby/sortby_test.go (right):

https://codereview.chromium.org/2657733002/diff/1/common/data/sortby/sortby_t...
common/data/sortby/sortby_test.go:1: package sortby
copyright

https://codereview.chromium.org/2657733002/diff/1/common/data/sortby/sortby_t...
common/data/sortby/sortby_test.go:35: {194, 771, 222},
add some partially equal keys, to actually hit the inner loop of Use

[iannucci, 2017-01-25 03:47:24]

https://codereview.chromium.org/2657733002/diff/1/common/data/sortby/sortby.go
File common/data/sortby/sortby.go (right):

https://codereview.chromium.org/2657733002/diff/1/common/data/sortby/sortby.g...
common/data/sortby/sortby.go:12: // elements. Multiple LessFns can be composed
with This and ThenBy to create
On 2017/01/25 03:43:34, Vadim Sh. wrote:
> what This and ThenBy?

Removed them (generated extra unnecessary indirection+syntax), will update
comment

https://codereview.chromium.org/2657733002/diff/1/common/data/sortby/sortby_t...
File common/data/sortby/sortby_test.go (right):

https://codereview.chromium.org/2657733002/diff/1/common/data/sortby/sortby_t...
common/data/sortby/sortby_test.go:1: package sortby
On 2017/01/25 03:43:34, Vadim Sh. wrote:
> copyright

Done.

https://codereview.chromium.org/2657733002/diff/1/common/data/sortby/sortby_t...
common/data/sortby/sortby_test.go:35: {194, 771, 222},
On 2017/01/25 03:43:34, Vadim Sh. wrote:
> add some partially equal keys, to actually hit the inner loop of Use

I just generated these with python, I'll add some as you suggest :)

[iannucci, 2017-01-25 03:48:05]

The CQ bit was checked by iannucci@chromium.org

[iannucci, 2017-01-25 03:48:05]

The patchset sent to the CQ was uploaded after l-g-t-m from vadimsh@chromium.org
Link to the patchset: https://codereview.chromium.org/2657733002/#ps40001
(title: "copyright")

[commit-bot: I haz the power, 2017-01-25 03:48:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 03:55:27]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485316085160590,
"parent_rev": "1b976d3ab8a37b86f086fca5dd8bc525dae674de", "commit_rev":
"80c0aea21b33925fd87eb92ee06e99395c33a5a1"}

[commit-bot: I haz the power, 2017-01-25 03:55:30]

Description was changed from

==========
Add sort function helper library.

Inspired by comments on https://github.com/golang/go/issues/16721.

This will be particularly handy when we get to use a version of go (1.8) which
has `sort.Slice`. But in the mean time, it's at least clearer and quicker than
hand-rolling Less methods (and potentially safer too!).

R=dnj@chromium.org, nodir@chromium.org, vadimsh@chromium.org
BUG=
==========

to

==========
Add sort function helper library.

Inspired by comments on https://github.com/golang/go/issues/16721.

This will be particularly handy when we get to use a version of go (1.8) which
has `sort.Slice`. But in the mean time, it's at least clearer and quicker than
hand-rolling Less methods (and potentially safer too!).

R=dnj@chromium.org, nodir@chromium.org, vadimsh@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2657733002
Committed:
https://github.com/luci/luci-go/commit/80c0aea21b33925fd87eb92ee06e99395c33a5a1
==========

[commit-bot: I haz the power, 2017-01-25 03:55:31]

Committed patchset #3 (id:40001) as
https://github.com/luci/luci-go/commit/80c0aea21b33925fd87eb92ee06e99395c33a5a1