components/suggestions/suggestions_service_impl.h - Issue 2657673004: Add shutdown notification and service refs to SyncServiceObserver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/suggestions/suggestions_service_impl.h

Issue 2657673004: Add shutdown notification and service refs to SyncServiceObserver. (Closed)

Patch Set: Chromeos fix Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/suggestions/suggestions_service_impl.h

diff --git a/components/suggestions/suggestions_service_impl.h b/components/suggestions/suggestions_service_impl.h

index 740bb8f8d9055781c74011b4a9231c15a7dcf16c..ff31fc84ce4a3a0ab23e070e83cb12f496caa220 100644

--- a/components/suggestions/suggestions_service_impl.h

+++ b/components/suggestions/suggestions_service_impl.h

@@ -112,7 +112,7 @@ class SuggestionsServiceImpl : public SuggestionsService,

static GURL BuildSuggestionsBlacklistClearURL();

// syncer::SyncServiceObserver implementation.

- void OnStateChanged() override;

+ void OnStateChanged(syncer::SyncService* sync) override;

// Sets default timestamp for suggestions which do not have expiry timestamp.

void SetDefaultExpiryTimestamp(SuggestionsProfile* suggestions,