components/password_manager/sync/browser/password_data_type_controller.cc - Issue 2657673004: Add shutdown notification and service refs to SyncServiceObserver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/sync/browser/password_data_type_controller.cc

Issue 2657673004: Add shutdown notification and service refs to SyncServiceObserver. (Closed)

Patch Set: Chromeos fix Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/sync/browser/password_data_type_controller.h ('k') | components/suggestions/suggestions_service_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/sync/browser/password_data_type_controller.cc

diff --git a/components/password_manager/sync/browser/password_data_type_controller.cc b/components/password_manager/sync/browser/password_data_type_controller.cc

index 12c35f38c90e6b0d3aacc06b90444aa8168e2104..ad1270b1eb8e95d1e98a1ce2daa70baa11f656c3 100644

--- a/components/password_manager/sync/browser/password_data_type_controller.cc

+++ b/components/password_manager/sync/browser/password_data_type_controller.cc

@@ -43,7 +43,7 @@ bool PasswordDataTypeController::StartModels() {

sync_client_->GetSyncService()->AddObserver(this);

- OnStateChanged();

+ OnStateChanged(sync_client_->GetSyncService());

return !!password_store_.get();

}

@@ -53,7 +53,7 @@ void PasswordDataTypeController::StopModels() {

sync_client_->GetSyncService()->RemoveObserver(this);

}

-void PasswordDataTypeController::OnStateChanged() {

+void PasswordDataTypeController::OnStateChanged(syncer::SyncService* sync) {

DCHECK(CalledOnValidThread());

state_changed_callback_.Run();

}