chrome/browser/sync/sync_global_error_unittest.cc - Issue 2657673004: Add shutdown notification and service refs to SyncServiceObserver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/sync_global_error_unittest.cc

Issue 2657673004: Add shutdown notification and service refs to SyncServiceObserver. (Closed)

Patch Set: Chromeos fix Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/sync_global_error_unittest.cc

diff --git a/chrome/browser/sync/sync_global_error_unittest.cc b/chrome/browser/sync/sync_global_error_unittest.cc

index ebe10dae84944a2aa55cf0da5c03c30d4d7abfbc..be3aa6ac01bf41c76a1ebb12f7162dfc8a8f01ee 100644

--- a/chrome/browser/sync/sync_global_error_unittest.cc

+++ b/chrome/browser/sync/sync_global_error_unittest.cc

@@ -92,7 +92,7 @@ void VerifySyncGlobalErrorResult(browser_sync::ProfileSyncServiceMock* service,

GoogleServiceAuthError auth_error(error_state);

EXPECT_CALL(*service, GetAuthError()).WillRepeatedly(ReturnRef(auth_error));

- error->OnStateChanged();

+ error->OnStateChanged(service);

EXPECT_EQ(is_error, error->HasError());

// If there is an error then a menu item and bubble view should be shown.