chrome/browser/sync/sync_error_notifier_ash_unittest.cc - Issue 2657673004: Add shutdown notification and service refs to SyncServiceObserver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/sync_error_notifier_ash_unittest.cc

Issue 2657673004: Add shutdown notification and service refs to SyncServiceObserver. (Closed)

Patch Set: Chromeos fix Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/sync_error_notifier_ash_unittest.cc

diff --git a/chrome/browser/sync/sync_error_notifier_ash_unittest.cc b/chrome/browser/sync/sync_error_notifier_ash_unittest.cc

index daafc9a606ba27469fa13732079d68938b518121..e91628654041cd42f15282b27ddce671bd02fe24 100644

--- a/chrome/browser/sync/sync_error_notifier_ash_unittest.cc

+++ b/chrome/browser/sync/sync_error_notifier_ash_unittest.cc

@@ -143,7 +143,7 @@ class SyncErrorNotifierTest : public AshTestBase {

EXPECT_CALL(*service_, GetAuthError()).WillRepeatedly(

ReturnRef(auth_error));

- error_controller_->OnStateChanged();

+ error_controller_->OnStateChanged(service_.get());

EXPECT_EQ(is_error, error_controller_->HasError());

// If there is an error we should see a notification.