Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 2657673002: Android: Guard against multiple stat uploads (Closed)

Created:
3 years, 11 months ago by Peter Wen
Modified:
3 years, 11 months ago
Reviewers:
Maria
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Android: Guard against multiple stat uploads Deferred startup handler should only record UMA at most once. Clients should add their own tasks for recording startup metrics. BUG=683944 Review-Url: https://codereview.chromium.org/2657673002 Cr-Commit-Position: refs/heads/master@{#445909} Committed: https://chromium.googlesource.com/chromium/src/+/1b94b8d69f748e9c8e686220c26bb87c1a461602

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java View 3 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Peter Wen
PTAL, this may decrease false positives in UMA, as mDeferredStartupInitializedForApp may be set only once ...
3 years, 11 months ago (2017-01-24 20:23:15 UTC) #2
Maria
lgtm
3 years, 11 months ago (2017-01-24 21:14:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2657673002/1
3 years, 11 months ago (2017-01-24 21:49:29 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 01:56:57 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1b94b8d69f748e9c8e686220c26b...

Powered by Google App Engine
This is Rietveld 408576698