Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2657653002: [Media>UI] Don't show media metadata on lockscreen in Incognito mode (Closed)

Created:
3 years, 11 months ago by Zhiqiang Zhang (Slow)
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[Media>UI] Don't show media metadata on lockscreen in Incognito mode Media notification content is marked as private in Incognito mode, so the content is hidden on lockscreen. For the same reason, we shouldn't show the artwork image on lockscreen and wearable devices. BUG=683111 Review-Url: https://codereview.chromium.org/2646793006 Cr-Commit-Position: refs/heads/master@{#445745} (cherry picked from commit 233f53ad273ef485ff5b12510b421a5ab4d429ec) Review-Url: https://codereview.chromium.org/2657653002 . Cr-Commit-Position: refs/branch-heads/2987@{#65} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/da78931d22bf9f4e20cf19b6c583a253f20ea0c9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Zhiqiang Zhang (Slow)
3 years, 11 months ago (2017-01-24 19:11:02 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
da78931d22bf9f4e20cf19b6c583a253f20ea0c9.

Powered by Google App Engine
This is Rietveld 408576698