ResourceFetcherTest: cleanup finalization

ResourceFetcherTest: cleanup finalization

Now the test cleanups WebURLLoaderMockFactory in TearDown, but
it would be better to do them in FetchTestingPlatformSupport's
destructor because it owns WebURLLoaderMockFactory.

TEST=blink_platform_unittests
BUG=655920
Review-Url: https://codereview.chromium.org/2657583004
Cr-Commit-Position: refs/heads/master@{#446283}
Committed: https://chromium.googlesource.com/chromium/src/+/ea8d9b39ef5247a3ff4ad2bbe8610d6bfd62dff2

[Takashi Toyoshima, 2017-01-25 06:05:33]

Description was changed from

==========
ResourceFetcherTest: cleanup finalization

Now the test cleanups WebURLLoaderMockFactory and memory cache in
TearDown, but it would be better to do them in FetchTestingPlatformSupport's
destructor because it owns WebURLLoaderMockFactory.

TEST=blink_platform_unittests
BUG=655920
==========

to

==========
ResourceFetcherTest: cleanup finalization

Now the test cleanups WebURLLoaderMockFactory and memory cache in
TearDown, but it would be better to do them in FetchTestingPlatformSupport's
destructor because it owns WebURLLoaderMockFactory.

TEST=blink_platform_unittests
BUG=655920
==========

[Takashi Toyoshima, 2017-01-25 06:05:34]

toyoshim@chromium.org changed reviewers:
+ yhirano@chromium.org

[Takashi Toyoshima, 2017-01-25 06:05:52]

PTAL, it's a minor cleanup.

[Takashi Toyoshima, 2017-01-25 06:05:58]

The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 06:06:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2017-01-25 06:13:26]

On 2017/01/25 06:05:52, toyoshim wrote:
> PTAL, it's a minor cleanup.

I'm not sure ~FetchTestingPlatformSupport should be responsible for MemoryCache
eviction. What do you think about it?

[Takashi Toyoshima, 2017-01-25 07:08:00]

Description was changed from

==========
ResourceFetcherTest: cleanup finalization

Now the test cleanups WebURLLoaderMockFactory and memory cache in
TearDown, but it would be better to do them in FetchTestingPlatformSupport's
destructor because it owns WebURLLoaderMockFactory.

TEST=blink_platform_unittests
BUG=655920
==========

to

==========
ResourceFetcherTest: cleanup finalization

Now the test cleanups WebURLLoaderMockFactory in TearDown, but
it would be better to do them in FetchTestingPlatformSupport's
destructor because it owns WebURLLoaderMockFactory.

TEST=blink_platform_unittests
BUG=655920
==========

[Takashi Toyoshima, 2017-01-25 07:09:27]

That's true and I do not have a strong reason here.
That's also why my CL description is unclear about it :(

How about the patch set 2?

[yhirano, 2017-01-25 07:13:00]

lgtm

Optionally you can evict resources from MemoryCache in ~ResourceFetcherTest.

[Takashi Toyoshima, 2017-01-26 08:20:12]

The CQ bit was checked by toyoshim@chromium.org

[Takashi Toyoshima, 2017-01-26 08:20:13]

The patchset sent to the CQ was uploaded after l-g-t-m from yhirano@chromium.org
Link to the patchset: https://codereview.chromium.org/2657583004/#ps40001
(title: "review #9")

[commit-bot: I haz the power, 2017-01-26 08:20:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 09:28:16]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485418812708800,
"parent_rev": "d02334dd908da947fffa103065c3b6ab8c30d6df", "commit_rev":
"ea8d9b39ef5247a3ff4ad2bbe8610d6bfd62dff2"}

[commit-bot: I haz the power, 2017-01-26 09:28:50]

Description was changed from

==========
ResourceFetcherTest: cleanup finalization

Now the test cleanups WebURLLoaderMockFactory in TearDown, but
it would be better to do them in FetchTestingPlatformSupport's
destructor because it owns WebURLLoaderMockFactory.

TEST=blink_platform_unittests
BUG=655920
==========

to

==========
ResourceFetcherTest: cleanup finalization

Now the test cleanups WebURLLoaderMockFactory in TearDown, but
it would be better to do them in FetchTestingPlatformSupport's
destructor because it owns WebURLLoaderMockFactory.

TEST=blink_platform_unittests
BUG=655920

Review-Url: https://codereview.chromium.org/2657583004
Cr-Commit-Position: refs/heads/master@{#446283}
Committed:
https://chromium.googlesource.com/chromium/src/+/ea8d9b39ef5247a3ff4ad2bbe861...
==========

[commit-bot: I haz the power, 2017-01-26 09:28:51]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ea8d9b39ef5247a3ff4ad2bbe861...