Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2657573002: Merged: Revert [TypeFeedbackVector] Root literal arrays in function literal slots (Closed)

Created:
3 years, 11 months ago by mvstanton
Modified:
3 years, 11 months ago
CC:
Hannes Payer (out of office), ulan, v8-merges_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com, Yang
Target Ref:
refs/pending/branch-heads/5.7
Project:
v8
Visibility:
Public.

Description

Merged: Revert [TypeFeedbackVector] Root literal arrays in function literal slots Revision: 55feaaea4 BUG=v8:5456 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=jochen@chromium.org Review-Url: https://codereview.chromium.org/2657573002 . Cr-Commit-Position: refs/branch-heads/5.7@{#18} Cr-Branched-From: 975e9a320b6eaf9f12280c35df98e013beb8f041-refs/heads/5.7.492@{#1} Cr-Branched-From: 8d76f0e3465a84bbf0bceab114900fbe75844e1f-refs/heads/master@{#42426} Committed: https://chromium.googlesource.com/v8/v8/+/74c25d3e354087fcd9f95ad359d802fe56914821

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+570 lines, -352 lines) Patch
M src/builtins/arm/builtins-arm.cc View 5 chunks +19 lines, -11 lines 0 comments Download
M src/builtins/arm64/builtins-arm64.cc View 5 chunks +14 lines, -8 lines 0 comments Download
M src/builtins/builtins-constructor.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/builtins/ia32/builtins-ia32.cc View 5 chunks +17 lines, -8 lines 0 comments Download
M src/builtins/mips/builtins-mips.cc View 4 chunks +19 lines, -11 lines 0 comments Download
M src/builtins/mips64/builtins-mips64.cc View 4 chunks +19 lines, -11 lines 0 comments Download
M src/builtins/ppc/builtins-ppc.cc View 5 chunks +15 lines, -8 lines 0 comments Download
M src/builtins/s390/builtins-s390.cc View 4 chunks +14 lines, -8 lines 0 comments Download
M src/builtins/x64/builtins-x64.cc View 4 chunks +14 lines, -8 lines 0 comments Download
M src/builtins/x87/builtins-x87.cc View 5 chunks +17 lines, -8 lines 0 comments Download
M src/compiler.cc View 4 chunks +19 lines, -12 lines 0 comments Download
M src/compiler/js-create-lowering.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M src/compiler/js-graph.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler/js-graph.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 1 chunk +1 line, -7 lines 0 comments Download
M src/contexts.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/contexts.cc View 6 chunks +27 lines, -8 lines 0 comments Download
M src/debug/liveedit.cc View 5 chunks +31 lines, -75 lines 0 comments Download
M src/heap/object-stats.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M src/objects.h View 7 chunks +19 lines, -6 lines 0 comments Download
M src/objects.cc View 8 chunks +67 lines, -52 lines 0 comments Download
M src/objects-inl.h View 2 chunks +2 lines, -13 lines 0 comments Download
M src/runtime/runtime-interpreter.cc View 1 chunk +1 line, -6 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 2 chunks +3 lines, -13 lines 0 comments Download
M src/type-feedback-vector.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 3 chunks +207 lines, -3 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-feedback-vector.cc View 1 chunk +1 line, -3 lines 0 comments Download
D test/mjsunit/strong-rooted-literals.js View 1 chunk +0 lines, -56 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
mvstanton
3 years, 11 months ago (2017-01-24 13:25:48 UTC) #1
mvstanton
NOTE: This script will no longer automatically update include/v8-version.h and create a tag. This is ...
3 years, 11 months ago (2017-01-24 13:25:50 UTC) #2
jochen (gone - plz use gerrit)
lgtm
3 years, 11 months ago (2017-01-24 13:51:02 UTC) #3
mvstanton
3 years, 11 months ago (2017-01-24 13:52:27 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
74c25d3e354087fcd9f95ad359d802fe56914821.

Powered by Google App Engine
This is Rietveld 408576698