[stubs] Add initializing constructor to CSA::Variable

[stubs] Add initializing constructor to CSA::Variable

It's a common pattern to create a Variable and immediately initialize
it. This adds a new constructor to make that pattern more natural.

BUG=

Review-Url: https://codereview.chromium.org/2657533003
Cr-Commit-Position: refs/heads/master@{#42649}
Committed: https://chromium.googlesource.com/v8/v8/+/a4183e59a7db2dc241070c8f02d6cb6f6545b23d

[jgruber, 2017-01-24 12:21:33]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 12:21:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 12:52:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 12:52:52]

Dry run: This issue passed the CQ dry run.

[jgruber, 2017-01-24 15:05:47]

jgruber@chromium.org changed reviewers:
+ ishell@chromium.org

[jgruber, 2017-01-24 15:05:47]

Hi Igor, please take a look - this adds a convenience ctor to CSA::Variable.

[jgruber, 2017-01-24 15:09:42]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 15:09:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2017-01-24 15:10:31]

lgtm

https://codereview.chromium.org/2657533003/diff/1/src/compiler/code-assembler.cc
File src/compiler/code-assembler.cc (right):

https://codereview.chromium.org/2657533003/diff/1/src/compiler/code-assembler...
src/compiler/code-assembler.cc:706: : impl_(new (assembler->zone()) Impl(rep)),
state_(assembler->state()) {
I think it's better to implement it as:
  : CodeAssemblerVariable(assembler, rep) {
  Bind(initial_value);
}

[jgruber, 2017-01-24 15:10:59]

jgruber@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[jgruber, 2017-01-24 15:10:59]

+mstarzinger for compiler/, PTAL.

[jgruber, 2017-01-24 15:16:05]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 15:16:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-01-24 15:16:26]

https://codereview.chromium.org/2657533003/diff/1/src/compiler/code-assembler.cc
File src/compiler/code-assembler.cc (right):

https://codereview.chromium.org/2657533003/diff/1/src/compiler/code-assembler...
src/compiler/code-assembler.cc:706: : impl_(new (assembler->zone()) Impl(rep)),
state_(assembler->state()) {
On 2017/01/24 15:10:31, Igor Sheludko wrote:
> I think it's better to implement it as:
>   : CodeAssemblerVariable(assembler, rep) {
>   Bind(initial_value);
> }

Done.

[commit-bot: I haz the power, 2017-01-24 15:23:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 15:23:47]

Dry run: Try jobs failed on following builders:
  v8_linux_chromium_gn_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/bu...)

[Michael Starzinger, 2017-01-25 09:22:10]

LGTM on "compiler" pieces.

[jgruber, 2017-01-25 09:41:35]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2017-01-25 09:41:35]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org
Link to the patchset: https://codereview.chromium.org/2657533003/#ps40001
(title: "Address comments")

[commit-bot: I haz the power, 2017-01-25 09:41:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 10:00:39]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485337295063620,
"parent_rev": "efc8cb16d783c923c690be93cd55ae37f947edca", "commit_rev":
"a4183e59a7db2dc241070c8f02d6cb6f6545b23d"}

[commit-bot: I haz the power, 2017-01-25 10:00:43]

Description was changed from

==========
[stubs] Add initializing constructor to CSA::Variable

It's a common pattern to create a Variable and immediately initialize
it. This adds a new constructor to make that pattern more natural.

BUG=
==========

to

==========
[stubs] Add initializing constructor to CSA::Variable

It's a common pattern to create a Variable and immediately initialize
it. This adds a new constructor to make that pattern more natural.

BUG=

Review-Url: https://codereview.chromium.org/2657533003
Cr-Commit-Position: refs/heads/master@{#42649}
Committed:
https://chromium.googlesource.com/v8/v8/+/a4183e59a7db2dc241070c8f02d6cb6f654...
==========

[commit-bot: I haz the power, 2017-01-25 10:00:44]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/a4183e59a7db2dc241070c8f02d6cb6f654...