Use new cipd ensure file parser.

Use new cipd ensure file parser.

R=vadimsh@chromium.org
BUG=663843
Review-Url: https://codereview.chromium.org/2657523002
Committed: https://github.com/luci/luci-go/commit/e28d78201c42f562b6edfdab20a24a40b968fe9a

[iannucci, 2017-01-25 04:32:03]

PTAL

https://codereview.chromium.org/2657523002/diff/20001/cipd/client/cmd/cipd/ma...
File cipd/client/cmd/cipd/main.go (right):

https://codereview.chromium.org/2657523002/diff/20001/cipd/client/cmd/cipd/ma...
cipd/client/cmd/cipd/main.go:742: }
this picks up the ServiceURL from the file. Modifying the clientOpts is a bit
messy, but that's how 'makeCipdClient' works. If it was something other than the
cmd module, I'd be concerned, but I think it's OK for now.

https://codereview.chromium.org/2657523002/diff/20001/cipd/client/cmd/cipd/ma...
cipd/client/cmd/cipd/main.go:759: return nil, cipd.Actions{}, errors.New("@Root
not yet supported")
This is supposed to prevent folks from using @Root with anything other than the
default root yet.

[Vadim Sh., 2017-01-25 04:36:30]

lgtm with nit

https://codereview.chromium.org/2657523002/diff/20001/cipd/client/cmd/cipd/ma...
File cipd/client/cmd/cipd/main.go (right):

https://codereview.chromium.org/2657523002/diff/20001/cipd/client/cmd/cipd/ma...
cipd/client/cmd/cipd/main.go:742: }
On 2017/01/25 04:32:03, iannucci wrote:
> this picks up the ServiceURL from the file. Modifying the clientOpts is a bit
> messy, but that's how 'makeCipdClient' works. If it was something other than
the
> cmd module, I'd be concerned, but I think it's OK for now.

It's fine, though I'm not sure what should take precedence in the case of:

cipd ensure <file> -service-url <url>

At least document that it picks the URL in the file.

[iannucci, 2017-01-25 04:56:26]

PTAL again. I manually tried the various permutations and it seems to work (I
don't think there's a straightforward way to write a test test for this? We
should probably think about slimming this package down into more testable
chunks. Maybe.)

https://codereview.chromium.org/2657523002/diff/20001/cipd/client/cmd/cipd/ma...
File cipd/client/cmd/cipd/main.go (right):

https://codereview.chromium.org/2657523002/diff/20001/cipd/client/cmd/cipd/ma...
cipd/client/cmd/cipd/main.go:742: }
On 2017/01/25 04:36:30, Vadim Sh. wrote:
> On 2017/01/25 04:32:03, iannucci wrote:
> > this picks up the ServiceURL from the file. Modifying the clientOpts is a
bit
> > messy, but that's how 'makeCipdClient' works. If it was something other than
> the
> > cmd module, I'd be concerned, but I think it's OK for now.
> 
> It's fine, though I'm not sure what should take precedence in the case of:
> 
> cipd ensure <file> -service-url <url>
> 
> At least document that it picks the URL in the file.

Done.

https://codereview.chromium.org/2657523002/diff/20001/cipd/client/cmd/cipd/ma...
cipd/client/cmd/cipd/main.go:754: })
Oops! Missed an err check here!

[Vadim Sh., 2017-01-25 05:02:43]

lgtm

[iannucci, 2017-01-25 06:42:16]

The CQ bit was checked by iannucci@chromium.org

[commit-bot: I haz the power, 2017-01-25 06:42:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 06:49:03]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485326536426240,
"parent_rev": "fe1e02304400e3d86e470d488e89de8e78131e93", "commit_rev":
"e28d78201c42f562b6edfdab20a24a40b968fe9a"}

[commit-bot: I haz the power, 2017-01-25 06:49:06]

Description was changed from

==========
Use new cipd ensure file parser.

R=vadimsh@chromium.org
BUG=663843
==========

to

==========
Use new cipd ensure file parser.

R=vadimsh@chromium.org
BUG=663843

Review-Url: https://codereview.chromium.org/2657523002
Committed:
https://github.com/luci/luci-go/commit/e28d78201c42f562b6edfdab20a24a40b968fe9a
==========

[commit-bot: I haz the power, 2017-01-25 06:49:07]

Committed patchset #3 (id:40001) as
https://github.com/luci/luci-go/commit/e28d78201c42f562b6edfdab20a24a40b968fe9a