Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(933)

Issue 26575006: [Android] Hide handles when the containing view moves (Closed)

Created:
7 years, 2 months ago by cjhopman
Modified:
7 years, 2 months ago
Reviewers:
joth
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, benm (inactive)
Visibility:
Public.

Description

[Android] Hide handles when the containing view moves We temporarily hide handles when there is a scroll or zoom in the content area. When the containing view is moved, we should also hide the handles. This is particularly important for webview where scrolling is often handled outside of the webview itself (and is sometimes mixed between the two). BUG=b/10892868 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=228850

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 4 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
cjhopman
joth: *
7 years, 2 months ago (2013-10-14 18:09:20 UTC) #1
joth
lgtm
7 years, 2 months ago (2013-10-15 06:12:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/26575006/5001
7 years, 2 months ago (2013-10-15 21:27:29 UTC) #3
commit-bot: I haz the power
7 years, 2 months ago (2013-10-16 03:20:05 UTC) #4
Message was sent while issue was closed.
Change committed as 228850

Powered by Google App Engine
This is Rietveld 408576698