Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2657493003:
Add TEAM/COMPONENT (Closed)
|
Created:
3 years, 11 months ago by ymzhang1 Modified:
3 years, 10 months ago Reviewers:
Ken Rockot(use gerrit already), jochen (gone - plz use gerrit), Ted C, Mike West, Jeffrey Yasskin, Renato Mangini (chromium) CC:
abarth-chromium, blink-reviews, blink-reviews-api_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, einbinder+watch-test-runner_chromium.org, extensions-reviews_chromium.org, haraken, jam, jochen+watch_chromium.org, mlamouri+watch-test-runner_chromium.org, mlamouri+watch-content_chromium.org, ortuno+watch_chromium.org, Peter Beverloo, scheib, scheib+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.
We are adding COMPONENT/TEAM information into OWNERS file. Please help us to
verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your
OWNERS files. Thanks.
Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping
Additional Information:
Component lists
https://bugs.chromium.org/p/chromium/adminComponents
BUG=679905
Review-Url: https://codereview.chromium.org/2657493003
Cr-Commit-Position: refs/heads/master@{#450765}
Committed: https://chromium.googlesource.com/chromium/src/+/057c179cad0a8b6e52cb22db4f117bb7f37968c1
Patch Set 1 #
Total comments: 10
Patch Set 2 : update team #
Total comments: 6
Patch Set 3 : remove uncertain component #
Total comments: 2
Patch Set 4 : undo blank line change #
Messages
Total messages: 27 (11 generated)
ymzhang@chromium.org changed reviewers: + jyasskin@chromium.org
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS file? Thank you very much!
I'm not a good person to check the paths that don't include "bluetooth". https://codereview.chromium.org/2657493003/diff/1/chrome/browser/ui/bluetooth... File chrome/browser/ui/bluetooth/OWNERS (right): https://codereview.chromium.org/2657493003/diff/1/chrome/browser/ui/bluetooth... chrome/browser/ui/bluetooth/OWNERS:6: # TEAM: bluetooth-dev@chromium.org web-bluetooth@ https://codereview.chromium.org/2657493003/diff/1/content/browser/bluetooth/O... File content/browser/bluetooth/OWNERS (right): https://codereview.chromium.org/2657493003/diff/1/content/browser/bluetooth/O... content/browser/bluetooth/OWNERS:5: # TEAM: bluetooth-dev@chromium.org This should be web-bluetooth@chromium.org https://codereview.chromium.org/2657493003/diff/1/content/common/bluetooth/OW... File content/common/bluetooth/OWNERS (right): https://codereview.chromium.org/2657493003/diff/1/content/common/bluetooth/OW... content/common/bluetooth/OWNERS:10: # TEAM: bluetooth-dev@chromium.org web-bluetooth@ https://codereview.chromium.org/2657493003/diff/1/third_party/WebKit/Source/m... File third_party/WebKit/Source/modules/bluetooth/OWNERS (right): https://codereview.chromium.org/2657493003/diff/1/third_party/WebKit/Source/m... third_party/WebKit/Source/modules/bluetooth/OWNERS:5: # TEAM: bluetooth-dev@chromium.org web-bluetooth@ https://codereview.chromium.org/2657493003/diff/1/third_party/WebKit/public/p... File third_party/WebKit/public/platform/modules/bluetooth/OWNERS (right): https://codereview.chromium.org/2657493003/diff/1/third_party/WebKit/public/p... third_party/WebKit/public/platform/modules/bluetooth/OWNERS:11: # TEAM: bluetooth-dev@chromium.org web-bluetooth@
ymzhang@chromium.org changed reviewers: + mangini@chromium.org, mkwst@chromium.org, rockot@chromium.org, tedchoc@chromium.org
mkwst@chromium.org: Could you help to review added COMPONENT information in content/shell/browser/layout_test/OWNERS? mangini@chromium.org, rockot@chromium.org: Could you please help to review the added COMPONENT/TEAM in third_party/google_appengine_cloudstorage/OWNERS? tedchoc@chromium.org: Could you please help to review the added TEAM/COMPONENT in components/location/OWNERS? Thank you very much! https://codereview.chromium.org/2657493003/diff/1/chrome/browser/ui/bluetooth... File chrome/browser/ui/bluetooth/OWNERS (right): https://codereview.chromium.org/2657493003/diff/1/chrome/browser/ui/bluetooth... chrome/browser/ui/bluetooth/OWNERS:6: # TEAM: bluetooth-dev@chromium.org On 2017/01/25 21:21:56, Jeffrey Yasskin wrote: > web-bluetooth@ Done. https://codereview.chromium.org/2657493003/diff/1/content/browser/bluetooth/O... File content/browser/bluetooth/OWNERS (right): https://codereview.chromium.org/2657493003/diff/1/content/browser/bluetooth/O... content/browser/bluetooth/OWNERS:5: # TEAM: bluetooth-dev@chromium.org On 2017/01/25 21:21:56, Jeffrey Yasskin wrote: > This should be mailto:web-bluetooth@chromium.org Done. https://codereview.chromium.org/2657493003/diff/1/content/common/bluetooth/OW... File content/common/bluetooth/OWNERS (right): https://codereview.chromium.org/2657493003/diff/1/content/common/bluetooth/OW... content/common/bluetooth/OWNERS:10: # TEAM: bluetooth-dev@chromium.org On 2017/01/25 21:21:56, Jeffrey Yasskin wrote: > web-bluetooth@ Done. https://codereview.chromium.org/2657493003/diff/1/third_party/WebKit/Source/m... File third_party/WebKit/Source/modules/bluetooth/OWNERS (right): https://codereview.chromium.org/2657493003/diff/1/third_party/WebKit/Source/m... third_party/WebKit/Source/modules/bluetooth/OWNERS:5: # TEAM: bluetooth-dev@chromium.org On 2017/01/25 21:21:56, Jeffrey Yasskin wrote: > web-bluetooth@ Done. https://codereview.chromium.org/2657493003/diff/1/third_party/WebKit/public/p... File third_party/WebKit/public/platform/modules/bluetooth/OWNERS (right): https://codereview.chromium.org/2657493003/diff/1/third_party/WebKit/public/p... third_party/WebKit/public/platform/modules/bluetooth/OWNERS:11: # TEAM: bluetooth-dev@chromium.org On 2017/01/25 21:21:56, Jeffrey Yasskin wrote: > web-bluetooth@ Done.
On 2017/01/25 at 22:59:46, ymzhang wrote: > mkwst@chromium.org: Could you help to review added COMPONENT information in content/shell/browser/layout_test/OWNERS? > > mangini@chromium.org, rockot@chromium.org: Could you please help to review the added COMPONENT/TEAM in third_party/google_appengine_cloudstorage/OWNERS? This has nothing to do with Blink storage. > > tedchoc@chromium.org: Could you please help to review the added TEAM/COMPONENT in components/location/OWNERS? > > Thank you very much! > > https://codereview.chromium.org/2657493003/diff/1/chrome/browser/ui/bluetooth... > File chrome/browser/ui/bluetooth/OWNERS (right): > > https://codereview.chromium.org/2657493003/diff/1/chrome/browser/ui/bluetooth... > chrome/browser/ui/bluetooth/OWNERS:6: # TEAM: bluetooth-dev@chromium.org > On 2017/01/25 21:21:56, Jeffrey Yasskin wrote: > > web-bluetooth@ > > Done. > > https://codereview.chromium.org/2657493003/diff/1/content/browser/bluetooth/O... > File content/browser/bluetooth/OWNERS (right): > > https://codereview.chromium.org/2657493003/diff/1/content/browser/bluetooth/O... > content/browser/bluetooth/OWNERS:5: # TEAM: bluetooth-dev@chromium.org > On 2017/01/25 21:21:56, Jeffrey Yasskin wrote: > > This should be mailto:web-bluetooth@chromium.org > > Done. > > https://codereview.chromium.org/2657493003/diff/1/content/common/bluetooth/OW... > File content/common/bluetooth/OWNERS (right): > > https://codereview.chromium.org/2657493003/diff/1/content/common/bluetooth/OW... > content/common/bluetooth/OWNERS:10: # TEAM: bluetooth-dev@chromium.org > On 2017/01/25 21:21:56, Jeffrey Yasskin wrote: > > web-bluetooth@ > > Done. > > https://codereview.chromium.org/2657493003/diff/1/third_party/WebKit/Source/m... > File third_party/WebKit/Source/modules/bluetooth/OWNERS (right): > > https://codereview.chromium.org/2657493003/diff/1/third_party/WebKit/Source/m... > third_party/WebKit/Source/modules/bluetooth/OWNERS:5: # TEAM: bluetooth-dev@chromium.org > On 2017/01/25 21:21:56, Jeffrey Yasskin wrote: > > web-bluetooth@ > > Done. > > https://codereview.chromium.org/2657493003/diff/1/third_party/WebKit/public/p... > File third_party/WebKit/public/platform/modules/bluetooth/OWNERS (right): > > https://codereview.chromium.org/2657493003/diff/1/third_party/WebKit/public/p... > third_party/WebKit/public/platform/modules/bluetooth/OWNERS:11: # TEAM: bluetooth-dev@chromium.org > On 2017/01/25 21:21:56, Jeffrey Yasskin wrote: > > web-bluetooth@ > > Done.
On 2017/01/26 23:53:08, Ken Rockot wrote: > On 2017/01/25 at 22:59:46, ymzhang wrote: > > mailto:mkwst@chromium.org: Could you help to review added COMPONENT information in > content/shell/browser/layout_test/OWNERS? > > > > mailto:mangini@chromium.org, mailto:rockot@chromium.org: Could you please help to review the > added COMPONENT/TEAM in third_party/google_appengine_cloudstorage/OWNERS? > > This has nothing to do with Blink storage. > > > > > mailto:tedchoc@chromium.org: Could you please help to review the added TEAM/COMPONENT > in components/location/OWNERS? > > > > Thank you very much! > > > > > https://codereview.chromium.org/2657493003/diff/1/chrome/browser/ui/bluetooth... > > File chrome/browser/ui/bluetooth/OWNERS (right): > > > > > https://codereview.chromium.org/2657493003/diff/1/chrome/browser/ui/bluetooth... > > chrome/browser/ui/bluetooth/OWNERS:6: # TEAM: mailto:bluetooth-dev@chromium.org > > On 2017/01/25 21:21:56, Jeffrey Yasskin wrote: > > > web-bluetooth@ > > > > Done. > > > > > https://codereview.chromium.org/2657493003/diff/1/content/browser/bluetooth/O... > > File content/browser/bluetooth/OWNERS (right): > > > > > https://codereview.chromium.org/2657493003/diff/1/content/browser/bluetooth/O... > > content/browser/bluetooth/OWNERS:5: # TEAM: mailto:bluetooth-dev@chromium.org > > On 2017/01/25 21:21:56, Jeffrey Yasskin wrote: > > > This should be mailto:web-bluetooth@chromium.org > > > > Done. > > > > > https://codereview.chromium.org/2657493003/diff/1/content/common/bluetooth/OW... > > File content/common/bluetooth/OWNERS (right): > > > > > https://codereview.chromium.org/2657493003/diff/1/content/common/bluetooth/OW... > > content/common/bluetooth/OWNERS:10: # TEAM: mailto:bluetooth-dev@chromium.org > > On 2017/01/25 21:21:56, Jeffrey Yasskin wrote: > > > web-bluetooth@ > > > > Done. > > > > > https://codereview.chromium.org/2657493003/diff/1/third_party/WebKit/Source/m... > > File third_party/WebKit/Source/modules/bluetooth/OWNERS (right): > > > > > https://codereview.chromium.org/2657493003/diff/1/third_party/WebKit/Source/m... > > third_party/WebKit/Source/modules/bluetooth/OWNERS:5: # TEAM: > mailto:bluetooth-dev@chromium.org > > On 2017/01/25 21:21:56, Jeffrey Yasskin wrote: > > > web-bluetooth@ > > > > Done. > > > > > https://codereview.chromium.org/2657493003/diff/1/third_party/WebKit/public/p... > > File third_party/WebKit/public/platform/modules/bluetooth/OWNERS (right): > > > > > https://codereview.chromium.org/2657493003/diff/1/third_party/WebKit/public/p... > > third_party/WebKit/public/platform/modules/bluetooth/OWNERS:11: # TEAM: > mailto:bluetooth-dev@chromium.org > > On 2017/01/25 21:21:56, Jeffrey Yasskin wrote: > > > web-bluetooth@ > > > > Done. Any suggestions of proper TEAM/COMPONENT for third_party/google_appengine_cloudstorage/OWNERS?
On Thu, Jan 26, 2017 at 4:08 PM, <ymzhang@chromium.org> wrote: > On 2017/01/26 23:53:08, Ken Rockot wrote: > > On 2017/01/25 at 22:59:46, ymzhang wrote: > > > mailto:mkwst@chromium.org: Could you help to review added COMPONENT > information in > > content/shell/browser/layout_test/OWNERS? > > > > > > mailto:mangini@chromium.org, mailto:rockot@chromium.org: Could you > please > help to review the > > added COMPONENT/TEAM in third_party/google_appengine_ > cloudstorage/OWNERS? > > > > This has nothing to do with Blink storage. > > > > > > > > mailto:tedchoc@chromium.org: Could you please help to review the added > TEAM/COMPONENT > > in components/location/OWNERS? > > > > > > Thank you very much! > > > > > > > > > https://codereview.chromium.org/2657493003/diff/1/chrome/ > browser/ui/bluetooth/OWNERS > > > File chrome/browser/ui/bluetooth/OWNERS (right): > > > > > > > > > https://codereview.chromium.org/2657493003/diff/1/chrome/ > browser/ui/bluetooth/OWNERS#newcode6 > > > chrome/browser/ui/bluetooth/OWNERS:6: # TEAM: > mailto:bluetooth-dev@chromium.org > > > On 2017/01/25 21:21:56, Jeffrey Yasskin wrote: > > > > web-bluetooth@ > > > > > > Done. > > > > > > > > > https://codereview.chromium.org/2657493003/diff/1/content/ > browser/bluetooth/OWNERS > > > File content/browser/bluetooth/OWNERS (right): > > > > > > > > > https://codereview.chromium.org/2657493003/diff/1/content/ > browser/bluetooth/OWNERS#newcode5 > > > content/browser/bluetooth/OWNERS:5: # TEAM: > mailto:bluetooth-dev@chromium.org > > > On 2017/01/25 21:21:56, Jeffrey Yasskin wrote: > > > > This should be mailto:web-bluetooth@chromium.org > > > > > > Done. > > > > > > > > > https://codereview.chromium.org/2657493003/diff/1/content/ > common/bluetooth/OWNERS > > > File content/common/bluetooth/OWNERS (right): > > > > > > > > > https://codereview.chromium.org/2657493003/diff/1/content/ > common/bluetooth/OWNERS#newcode10 > > > content/common/bluetooth/OWNERS:10: # TEAM: > mailto:bluetooth-dev@chromium.org > > > On 2017/01/25 21:21:56, Jeffrey Yasskin wrote: > > > > web-bluetooth@ > > > > > > Done. > > > > > > > > > https://codereview.chromium.org/2657493003/diff/1/third_ > party/WebKit/Source/modules/bluetooth/OWNERS > > > File third_party/WebKit/Source/modules/bluetooth/OWNERS (right): > > > > > > > > > https://codereview.chromium.org/2657493003/diff/1/third_ > party/WebKit/Source/modules/bluetooth/OWNERS#newcode5 > > > third_party/WebKit/Source/modules/bluetooth/OWNERS:5: # TEAM: > > mailto:bluetooth-dev@chromium.org > > > On 2017/01/25 21:21:56, Jeffrey Yasskin wrote: > > > > web-bluetooth@ > > > > > > Done. > > > > > > > > > https://codereview.chromium.org/2657493003/diff/1/third_ > party/WebKit/public/platform/modules/bluetooth/OWNERS > > > File third_party/WebKit/public/platform/modules/bluetooth/OWNERS > (right): > > > > > > > > > https://codereview.chromium.org/2657493003/diff/1/third_ > party/WebKit/public/platform/modules/bluetooth/OWNERS#newcode11 > > > third_party/WebKit/public/platform/modules/bluetooth/OWNERS:11: # > TEAM: > > mailto:bluetooth-dev@chromium.org > > > On 2017/01/25 21:21:56, Jeffrey Yasskin wrote: > > > > web-bluetooth@ > > > > > > Done. > > Any suggestions of proper TEAM/COMPONENT for > third_party/google_appengine_cloudstorage/OWNERS? > I don't think it should have one. It's only used by the extensions documentation server at the moment, but it's just a third-party library with no strict limitation that it only be used by the extensions system. Classifying it with a chrome component doesn't make much sense to me. > > https://codereview.chromium.org/2657493003/ > -- You received this message because you are subscribed to the Google Groups "Blink Reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-reviews+unsubscribe@chromium.org.
On Thu, Jan 26, 2017 at 4:08 PM, <ymzhang@chromium.org> wrote: > On 2017/01/26 23:53:08, Ken Rockot wrote: > > On 2017/01/25 at 22:59:46, ymzhang wrote: > > > mailto:mkwst@chromium.org: Could you help to review added COMPONENT > information in > > content/shell/browser/layout_test/OWNERS? > > > > > > mailto:mangini@chromium.org, mailto:rockot@chromium.org: Could you > please > help to review the > > added COMPONENT/TEAM in third_party/google_appengine_ > cloudstorage/OWNERS? > > > > This has nothing to do with Blink storage. > > > > > > > > mailto:tedchoc@chromium.org: Could you please help to review the added > TEAM/COMPONENT > > in components/location/OWNERS? > > > > > > Thank you very much! > > > > > > > > > https://codereview.chromium.org/2657493003/diff/1/chrome/ > browser/ui/bluetooth/OWNERS > > > File chrome/browser/ui/bluetooth/OWNERS (right): > > > > > > > > > https://codereview.chromium.org/2657493003/diff/1/chrome/ > browser/ui/bluetooth/OWNERS#newcode6 > > > chrome/browser/ui/bluetooth/OWNERS:6: # TEAM: > mailto:bluetooth-dev@chromium.org > > > On 2017/01/25 21:21:56, Jeffrey Yasskin wrote: > > > > web-bluetooth@ > > > > > > Done. > > > > > > > > > https://codereview.chromium.org/2657493003/diff/1/content/ > browser/bluetooth/OWNERS > > > File content/browser/bluetooth/OWNERS (right): > > > > > > > > > https://codereview.chromium.org/2657493003/diff/1/content/ > browser/bluetooth/OWNERS#newcode5 > > > content/browser/bluetooth/OWNERS:5: # TEAM: > mailto:bluetooth-dev@chromium.org > > > On 2017/01/25 21:21:56, Jeffrey Yasskin wrote: > > > > This should be mailto:web-bluetooth@chromium.org > > > > > > Done. > > > > > > > > > https://codereview.chromium.org/2657493003/diff/1/content/ > common/bluetooth/OWNERS > > > File content/common/bluetooth/OWNERS (right): > > > > > > > > > https://codereview.chromium.org/2657493003/diff/1/content/ > common/bluetooth/OWNERS#newcode10 > > > content/common/bluetooth/OWNERS:10: # TEAM: > mailto:bluetooth-dev@chromium.org > > > On 2017/01/25 21:21:56, Jeffrey Yasskin wrote: > > > > web-bluetooth@ > > > > > > Done. > > > > > > > > > https://codereview.chromium.org/2657493003/diff/1/third_ > party/WebKit/Source/modules/bluetooth/OWNERS > > > File third_party/WebKit/Source/modules/bluetooth/OWNERS (right): > > > > > > > > > https://codereview.chromium.org/2657493003/diff/1/third_ > party/WebKit/Source/modules/bluetooth/OWNERS#newcode5 > > > third_party/WebKit/Source/modules/bluetooth/OWNERS:5: # TEAM: > > mailto:bluetooth-dev@chromium.org > > > On 2017/01/25 21:21:56, Jeffrey Yasskin wrote: > > > > web-bluetooth@ > > > > > > Done. > > > > > > > > > https://codereview.chromium.org/2657493003/diff/1/third_ > party/WebKit/public/platform/modules/bluetooth/OWNERS > > > File third_party/WebKit/public/platform/modules/bluetooth/OWNERS > (right): > > > > > > > > > https://codereview.chromium.org/2657493003/diff/1/third_ > party/WebKit/public/platform/modules/bluetooth/OWNERS#newcode11 > > > third_party/WebKit/public/platform/modules/bluetooth/OWNERS:11: # > TEAM: > > mailto:bluetooth-dev@chromium.org > > > On 2017/01/25 21:21:56, Jeffrey Yasskin wrote: > > > > web-bluetooth@ > > > > > > Done. > > Any suggestions of proper TEAM/COMPONENT for > third_party/google_appengine_cloudstorage/OWNERS? > I don't think it should have one. It's only used by the extensions documentation server at the moment, but it's just a third-party library with no strict limitation that it only be used by the extensions system. Classifying it with a chrome component doesn't make much sense to me. > > https://codereview.chromium.org/2657493003/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
https://codereview.chromium.org/2657493003/diff/20001/components/location/OWNERS File components/location/OWNERS (right): https://codereview.chromium.org/2657493003/diff/20001/components/location/OWN... components/location/OWNERS:5: # COMPONENT: Blink>Location this isn't really a blink related a component. It is just a helper utility for interacting with androids location apis. I don't know of a team or component that is valid here...these might be right, but no idea.
jochen@chromium.org changed reviewers: + jochen@chromium.org
https://codereview.chromium.org/2657493003/diff/20001/content/shell/browser/l... File content/shell/browser/layout_test/OWNERS (right): https://codereview.chromium.org/2657493003/diff/20001/content/shell/browser/l... content/shell/browser/layout_test/OWNERS:7: # COMPONENT: Blink>Layout that is incorrect imo https://codereview.chromium.org/2657493003/diff/20001/third_party/google_appe... File third_party/google_appengine_cloudstorage/OWNERS (right): https://codereview.chromium.org/2657493003/diff/20001/third_party/google_appe... third_party/google_appengine_cloudstorage/OWNERS:6: # COMPONENT: Blink>Storage not sure about that either
https://codereview.chromium.org/2657493003/diff/20001/components/location/OWNERS File components/location/OWNERS (right): https://codereview.chromium.org/2657493003/diff/20001/components/location/OWN... components/location/OWNERS:5: # COMPONENT: Blink>Location On 2017/01/27 04:15:55, Ted C wrote: > this isn't really a blink related a component. It is just a helper utility for > interacting with androids location apis. > > I don't know of a team or component that is valid here...these might be right, > but no idea. Done. https://codereview.chromium.org/2657493003/diff/20001/content/shell/browser/l... File content/shell/browser/layout_test/OWNERS (right): https://codereview.chromium.org/2657493003/diff/20001/content/shell/browser/l... content/shell/browser/layout_test/OWNERS:7: # COMPONENT: Blink>Layout On 2017/01/27 04:19:29, jochen (travelling til Feb 4) wrote: > that is incorrect imo I'll remove component information in this file. https://codereview.chromium.org/2657493003/diff/20001/third_party/google_appe... File third_party/google_appengine_cloudstorage/OWNERS (right): https://codereview.chromium.org/2657493003/diff/20001/third_party/google_appe... third_party/google_appengine_cloudstorage/OWNERS:6: # COMPONENT: Blink>Storage On 2017/01/27 04:19:29, jochen (travelling til Feb 4) wrote: > not sure about that either I'll remove this team/component information.
Description was changed from ========== Add TEAM/COMPONENT BUG=679905 ========== to ========== BUG=679905 We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files https://docs.google.com/document/d/1jty6UsFMW9-SYgpQC-ztEc3lltziOQBBArMkROCST... Proposal about how to get suggested component for directory. https://docs.google.com/document/d/1G0UD01aNXdzPsJO-gTLEQiKkDV8XU2XBbi_Gm4g9J... TEAM-COMPONENT mapping https://docs.google.com/spreadsheets/d/19JEFMvsxD3eThyGiJRqAjcpx362LHUDdVzICA... ==========
Description was changed from ========== BUG=679905 We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files https://docs.google.com/document/d/1jty6UsFMW9-SYgpQC-ztEc3lltziOQBBArMkROCST... Proposal about how to get suggested component for directory. https://docs.google.com/document/d/1G0UD01aNXdzPsJO-gTLEQiKkDV8XU2XBbi_Gm4g9J... TEAM-COMPONENT mapping https://docs.google.com/spreadsheets/d/19JEFMvsxD3eThyGiJRqAjcpx362LHUDdVzICA... ========== to ========== [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 ==========
https://codereview.chromium.org/2657493003/diff/40001/content/shell/browser/l... File content/shell/browser/layout_test/OWNERS (left): https://codereview.chromium.org/2657493003/diff/40001/content/shell/browser/l... content/shell/browser/layout_test/OWNERS:4: nit. please undo this change
Patchset #4 (id:60001) has been deleted
Patchset #4 (id:80001) has been deleted
Patchset #4 (id:100001) has been deleted
https://codereview.chromium.org/2657493003/diff/40001/content/shell/browser/l... File content/shell/browser/layout_test/OWNERS (left): https://codereview.chromium.org/2657493003/diff/40001/content/shell/browser/l... content/shell/browser/layout_test/OWNERS:4: On 2017/02/14 12:18:55, jochen wrote: > nit. please undo this change Done.
deferring to jyasskin@
lgtm
The CQ bit was checked by ymzhang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 120001, "attempt_start_ts": 1487181487953750,
"parent_rev": "97f1bc8106b41307d0b02eae771daa5ef266ef4f", "commit_rev":
"057c179cad0a8b6e52cb22db4f117bb7f37968c1"}
Message was sent while issue was closed.
Description was changed from ========== [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 ========== to ========== [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 Review-Url: https://codereview.chromium.org/2657493003 Cr-Commit-Position: refs/heads/master@{#450765} Committed: https://chromium.googlesource.com/chromium/src/+/057c179cad0a8b6e52cb22db4f11... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:120001) as https://chromium.googlesource.com/chromium/src/+/057c179cad0a8b6e52cb22db4f11... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
