Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2657463004: Merged: Squashed multiple commits. (Closed)

Created:
3 years, 11 months ago by Jakob Kummerow
Modified:
3 years, 11 months ago
Reviewers:
jbroman
CC:
ulan, v8-merges_googlegroups.com, v8-reviews_googlegroups.com
Target Ref:
refs/pending/branch-heads/5.7
Project:
v8
Visibility:
Public.

Description

Merged: Squashed multiple commits. Merged: Trigger OOM crash if no memory returned in v8::ArrayBuffer::New and v8::SharedArrayBuffer::New. Revision: ca0f957329828c61f02437f640ed8004a549018a Merged: ValueSerializer: Fail decode if no memory is available when decoding ArrayBuffer. Revision: 5e30385d62496544adacc7cb8e3c86694854b9f1 BUG=chromium:681843 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=jbroman@chromium.org Review-Url: https://codereview.chromium.org/2657463004 . Cr-Commit-Position: refs/branch-heads/5.7@{#20} Cr-Branched-From: 975e9a320b6eaf9f12280c35df98e013beb8f041-refs/heads/5.7.492@{#1} Cr-Branched-From: 8d76f0e3465a84bbf0bceab114900fbe75844e1f-refs/heads/master@{#42426} Committed: https://chromium.googlesource.com/v8/v8/+/94651de33258436a8d07da656486724be8c6cfed

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -5 lines) Patch
M src/api.cc View 2 chunks +11 lines, -3 lines 0 comments Download
M src/value-serializer.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M test/unittests/value-serializer-unittest.cc View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jakob Kummerow
3 years, 11 months ago (2017-01-24 15:40:22 UTC) #1
Jakob Kummerow
NOTE: This script will no longer automatically update include/v8-version.h and create a tag. This is ...
3 years, 11 months ago (2017-01-24 15:40:24 UTC) #2
jbroman
lgtm
3 years, 11 months ago (2017-01-24 15:40:47 UTC) #3
Jakob Kummerow
3 years, 11 months ago (2017-01-24 15:41:16 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
94651de33258436a8d07da656486724be8c6cfed.

Powered by Google App Engine
This is Rietveld 408576698