[wasm] Errors in names section do not fail the whole module.

[wasm] Errors in names section do not fail the whole module.

R=ahaas@chromium.org
BUG=v8:5882
Review-Url: https://codereview.chromium.org/2657463003
Cr-Commit-Position: refs/heads/master@{#42629}
Committed: https://chromium.googlesource.com/v8/v8/+/a920c0d92bd5d1c59a23ba4c103c96d7724d0460

[titzer, 2017-01-24 10:57:43]

The CQ bit was checked by titzer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 10:57:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 11:12:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 11:12:58]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[titzer, 2017-01-24 11:41:16]

The CQ bit was checked by titzer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 11:41:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 12:14:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 12:14:15]

Dry run: This issue passed the CQ dry run.

[ahaas, 2017-01-24 12:40:14]

lgtm with nits

https://codereview.chromium.org/2657463003/diff/20001/src/wasm/module-decoder.cc
File src/wasm/module-decoder.cc (right):

https://codereview.chromium.org/2657463003/diff/20001/src/wasm/module-decoder...
src/wasm/module-decoder.cc:613: Decoder inner(start_, pc_, end_);
Can we tell a developer in some way that the names section is broken? I could
imagine that hiding problems in the names section could cause an unpleasant
debugging experience.

https://codereview.chromium.org/2657463003/diff/20001/test/mjsunit/wasm/names.js
File test/mjsunit/wasm/names.js (right):

https://codereview.chromium.org/2657463003/diff/20001/test/mjsunit/wasm/names...
test/mjsunit/wasm/names.js:5: // Flags: --expose-wasm
There is no need for --expose-wasm anymore, is there?

[titzer, 2017-01-24 12:42:57]

https://codereview.chromium.org/2657463003/diff/20001/src/wasm/module-decoder.cc
File src/wasm/module-decoder.cc (right):

https://codereview.chromium.org/2657463003/diff/20001/src/wasm/module-decoder...
src/wasm/module-decoder.cc:613: Decoder inner(start_, pc_, end_);
On 2017/01/24 12:40:14, ahaas wrote:
> Can we tell a developer in some way that the names section is broken? I could
> imagine that hiding problems in the names section could cause an unpleasant
> debugging experience.

Added a TODO.

https://codereview.chromium.org/2657463003/diff/20001/test/mjsunit/wasm/names.js
File test/mjsunit/wasm/names.js (right):

https://codereview.chromium.org/2657463003/diff/20001/test/mjsunit/wasm/names...
test/mjsunit/wasm/names.js:5: // Flags: --expose-wasm
On 2017/01/24 12:40:14, ahaas wrote:
> There is no need for --expose-wasm anymore, is there?

Gonna keep it, just in case we get turned off :-)

[titzer, 2017-01-24 12:43:16]

The CQ bit was checked by titzer@chromium.org

[titzer, 2017-01-24 12:43:16]

The patchset sent to the CQ was uploaded after l-g-t-m from ahaas@chromium.org
Link to the patchset: https://codereview.chromium.org/2657463003/#ps40001
(title: "Added a TODO")

[commit-bot: I haz the power, 2017-01-24 12:43:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 13:13:30]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485261796255870,
"parent_rev": "4894bbd4399aeabc994a4e2579809d32ea8b4c29", "commit_rev":
"a920c0d92bd5d1c59a23ba4c103c96d7724d0460"}

[commit-bot: I haz the power, 2017-01-24 13:13:34]

Description was changed from

==========
[wasm] Errors in names section do not fail the whole module.

R=ahaas@chromium.org
BUG=v8:5882
==========

to

==========
[wasm] Errors in names section do not fail the whole module.

R=ahaas@chromium.org
BUG=v8:5882

Review-Url: https://codereview.chromium.org/2657463003
Cr-Commit-Position: refs/heads/master@{#42629}
Committed:
https://chromium.googlesource.com/v8/v8/+/a920c0d92bd5d1c59a23ba4c103c96d7724...
==========

[commit-bot: I haz the power, 2017-01-24 13:13:35]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/a920c0d92bd5d1c59a23ba4c103c96d7724...