Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 2657453006: Move BrowsingDataFilterBuilder[Impl] to content/ (Closed)

Created:
3 years, 11 months ago by msramek
Modified:
3 years, 10 months ago
Reviewers:
Mike West, jam
CC:
chromium-reviews, darin-cc_chromium.org, jam, markusheintz_, msramek+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move BrowsingDataFilterBuilder[Impl] to content/ BrowsingDataFilterBuilder[Impl] is to be used by both content/ and chrome/ parts of the browsing_data/ codebase. Therefore, we move it to content/browsing_data with a public interface in content/public/. Note that this CL is the *first* part of browsing_data/ codebase that is moving to content/; BrowsingDataFilterBuilder has no users in content/ yet. BrowsingDataRemover[Impl] will move soon after. The intention of this CL is to make the upcoming change smaller. BUG=668114 Review-Url: https://codereview.chromium.org/2657453006 Cr-Commit-Position: refs/heads/master@{#447983} Committed: https://chromium.googlesource.com/chromium/src/+/a3c7cfd551d34f0edd4fc8c84d3aa172eba303c6

Patch Set 1 #

Patch Set 2 : Android. #

Patch Set 3 : Added owners. #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -944 lines) Patch
M chrome/browser/BUILD.gn View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/android/preferences/pref_service_bridge.cc View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download
D chrome/browser/browsing_data/browsing_data_filter_builder.h View 1 chunk +0 lines, -98 lines 0 comments Download
D chrome/browser/browsing_data/browsing_data_filter_builder_impl.h View 1 chunk +0 lines, -43 lines 0 comments Download
D chrome/browser/browsing_data/browsing_data_filter_builder_impl.cc View 1 chunk +0 lines, -216 lines 0 comments Download
D chrome/browser/browsing_data/browsing_data_filter_builder_impl_unittest.cc View 1 chunk +0 lines, -546 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover.h View 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover_browsertest.cc View 3 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover_delegate.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover_impl.h View 5 chunks +14 lines, -12 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover_impl.cc View 3 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover_impl_unittest.cc View 1 2 3 3 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc View 1 2 3 3 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc View 1 2 3 3 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 3 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client_unittest.cc View 3 chunks +2 lines, -1 line 0 comments Download
M chrome/test/BUILD.gn View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/BUILD.gn View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A content/browser/browsing_data/OWNERS View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
A + content/browser/browsing_data/browsing_data_filter_builder_impl.h View 2 chunks +10 lines, -5 lines 0 comments Download
A + content/browser/browsing_data/browsing_data_filter_builder_impl.cc View 3 chunks +5 lines, -1 line 0 comments Download
A + content/browser/browsing_data/browsing_data_filter_builder_impl_unittest.cc View 3 chunks +6 lines, -1 line 0 comments Download
M content/public/browser/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A + content/public/browser/browsing_data_filter_builder.h View 5 chunks +9 lines, -4 lines 0 comments Download
M content/test/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 31 (20 generated)
msramek
Hi Mike and John, Please have a look! This is the first part of browsing_data/ ...
3 years, 11 months ago (2017-01-25 12:50:21 UTC) #4
jam
lgtm Please add OWNERS file in content/browser/browsing_data
3 years, 11 months ago (2017-01-25 18:41:30 UTC) #11
msramek
On 2017/01/25 18:41:30, jam wrote: > lgtm Thanks! > > Please add OWNERS file in ...
3 years, 11 months ago (2017-01-25 18:46:43 UTC) #12
msramek
Mike, friendly ping :-)
3 years, 10 months ago (2017-01-30 09:39:46 UTC) #17
Mike West
LGTM. Sorry, I'm at offsites all week, so I'm super slow.
3 years, 10 months ago (2017-02-02 20:51:47 UTC) #18
msramek
Acknowledged! Thanks :)
3 years, 10 months ago (2017-02-03 11:53:51 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2657453006/40001
3 years, 10 months ago (2017-02-03 11:54:22 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/146862) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 10 months ago (2017-02-03 11:56:22 UTC) #24
msramek
Rebased, fixed a tiny merge conflict, trying again. What are the odds that in a ...
3 years, 10 months ago (2017-02-03 12:13:05 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2657453006/60001
3 years, 10 months ago (2017-02-03 12:19:28 UTC) #28
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 13:34:49 UTC) #31
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/a3c7cfd551d34f0edd4fc8c84d3a...

Powered by Google App Engine
This is Rietveld 408576698