Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 2657453005: No need to define SK_SCALAR_IS_FLOAT (Closed)

Created:
3 years, 11 months ago by hal.canary
Modified:
3 years, 11 months ago
Reviewers:
_cary, dsinclair, caryclark
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

No need to define SK_SCALAR_IS_FLOAT This is already the default value and is the only supported case. Review-Url: https://codereview.chromium.org/2657453005 Committed: https://pdfium.googlesource.com/pdfium/+/bea4330c8805b87dedb79d2c83443d15e3e068a2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M skia/config/SkUserConfig.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
hal.canary
3 years, 11 months ago (2017-01-24 18:13:18 UTC) #6
caryclark
sorry, not an OWNER
3 years, 11 months ago (2017-01-24 18:40:00 UTC) #7
dsinclair
lgtm
3 years, 11 months ago (2017-01-24 18:45:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2657453005/1
3 years, 11 months ago (2017-01-24 18:45:15 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 19:03:00 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/bea4330c8805b87dedb79d2c83443d15e3e0...

Powered by Google App Engine
This is Rietveld 408576698