Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 2657433002: Remove obsolete include of build_overrides/v8.gni (Closed)

Created:
3 years, 11 months ago by brettw
Modified:
3 years, 11 months ago
Reviewers:
Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove obsolete include of build_overrides/v8.gni This file is no longer needed. BUG=684096 Review-Url: https://codereview.chromium.org/2657433002 Committed: https://pdfium.googlesource.com/pdfium/+/7a82a6294a34db85cf5cfa4b6a994708f7a915e7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M samples/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
brettw
3 years, 11 months ago (2017-01-23 22:21:26 UTC) #2
Wei Li
lgtm
3 years, 11 months ago (2017-01-23 23:35:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2657433002/1
3 years, 11 months ago (2017-01-23 23:52:53 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 00:08:42 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/7a82a6294a34db85cf5cfa4b6a994708f7a9...

Powered by Google App Engine
This is Rietveld 408576698