Moved nonproperty isLink to be generated in ComputedStyleBase.

Moved nonproperty isLink to be generated in ComputedStyleBase.

Move the nonproperty field isLink to be generated in ComputedStyleBase.
Also moved getter / setter methods to be generated in ComputedStyleBase.

Diff: https://gist.github.com/76592244b306fb4f5c953e0f67687d53/revisions

BUG=628043
Review-Url: https://codereview.chromium.org/2657423004
Cr-Commit-Position: refs/heads/master@{#456948}
Committed: https://chromium.googlesource.com/chromium/src/+/335e4d5926d1360df2a0f973a760ae9a9abe054a

[shend, 2017-02-02 03:02:58]

shend@chromium.org changed reviewers:
+ nainar@chromium.org

[shend, 2017-02-02 03:02:58]

Hi Naina, PTAL :)

[shend, 2017-02-02 03:03:08]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 03:03:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 03:05:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 03:05:30]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[nainar, 2017-02-03 06:31:45]

lgtm

[shend, 2017-03-14 06:32:22]

Description was changed from

==========
Moved nonproperty isLink to be generated in ComputedStyleBase.

Move the nonproperty field isLink to be generated in ComputedStyleBase.
Also moved getter / setter methods to be generated in ComputedStyleBase.

BUG=628043
==========

to

==========
Moved nonproperty isLink to be generated in ComputedStyleBase.

Move the nonproperty field isLink to be generated in ComputedStyleBase.
Also moved getter / setter methods to be generated in ComputedStyleBase.

Diff: https://gist.github.com/76592244b306fb4f5c953e0f67687d53/revisions

BUG=628043
==========

[shend, 2017-03-14 06:32:52]

shend@chromium.org changed reviewers:
+ meade@chromium.org

[shend, 2017-03-14 06:32:52]

Hi Eddy, PTAL

[shend, 2017-03-14 06:32:56]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 06:33:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[meade_UTC10, 2017-03-14 06:59:09]

lgtm

https://codereview.chromium.org/2657423004/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/build/scripts/make_computed_style_base.py
(right):

https://codereview.chromium.org/2657423004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/build/scripts/make_computed_style_base.py:30: # Is
this element a link?
I wonder if comments like this are actually helpful? isLink implies it
represents whether the ComputedStyle is for a link anyway...

[shend, 2017-03-14 07:21:40]

https://codereview.chromium.org/2657423004/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/build/scripts/make_computed_style_base.py
(right):

https://codereview.chromium.org/2657423004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/build/scripts/make_computed_style_base.py:30: # Is
this element a link?
On 2017/03/14 at 06:59:09, Eddy wrote:
> I wonder if comments like this are actually helpful? isLink implies it
represents whether the ComputedStyle is for a link anyway...

lol true

[shend, 2017-03-14 22:20:18]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 22:20:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 00:35:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 00:35:22]

Dry run: This issue passed the CQ dry run.

[shend, 2017-03-15 02:02:37]

The CQ bit was checked by shend@chromium.org

[shend, 2017-03-15 02:02:37]

The patchset sent to the CQ was uploaded after l-g-t-m from nainar@chromium.org,
meade@chromium.org
Link to the patchset: https://codereview.chromium.org/2657423004/#ps100001
(title: "Address comments")

[commit-bot: I haz the power, 2017-03-15 02:03:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 02:08:13]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1489543357549390,
"parent_rev": "9d1a37598c975048e0fc98a0b99b262d074d5145", "commit_rev":
"335e4d5926d1360df2a0f973a760ae9a9abe054a"}

[commit-bot: I haz the power, 2017-03-15 02:08:56]

Description was changed from

==========
Moved nonproperty isLink to be generated in ComputedStyleBase.

Move the nonproperty field isLink to be generated in ComputedStyleBase.
Also moved getter / setter methods to be generated in ComputedStyleBase.

Diff: https://gist.github.com/76592244b306fb4f5c953e0f67687d53/revisions

BUG=628043
==========

to

==========
Moved nonproperty isLink to be generated in ComputedStyleBase.

Move the nonproperty field isLink to be generated in ComputedStyleBase.
Also moved getter / setter methods to be generated in ComputedStyleBase.

Diff: https://gist.github.com/76592244b306fb4f5c953e0f67687d53/revisions

BUG=628043

Review-Url: https://codereview.chromium.org/2657423004
Cr-Commit-Position: refs/heads/master@{#456948}
Committed:
https://chromium.googlesource.com/chromium/src/+/335e4d5926d1360df2a0f973a760...
==========

[commit-bot: I haz the power, 2017-03-15 02:08:56]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/335e4d5926d1360df2a0f973a760...